Improve the SUSHI output String buffer #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now automatically increases size if the current SUSHI output line is larger than the buffer initial size, preventing an IndexOutOfBoundsException being thrown. The StringBuilder is reused in the same way the old byte array was. to preserve performance. It solves #712.
|
Is it possible to create a simple test to describe the expected behaviour? The code does seem cleaner with these fixes. |
|
Sure. I've refactored the code a bit to facilitate testing and have added simple tests for MySushiHandler. Is it fine like that? |
|
That does look better! I have another PR that refines those tests slightly: https://github.com/qligier/fhir-ig-publisher/pull/1 Could you take a look? |
|
Thank you for improving this PR, I've merged your commit. |
dotasek
approved these changes
Jun 29, 2023
dotasek
approved these changes
Jun 29, 2023
|
This was tested locally using the compiled CLI jar to confirm that SUSHI output is still generated and matches previous runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now automatically increases size if the current SUSHI output line is larger than the buffer initial size, preventing an IndexOutOfBoundsException being thrown. The StringBuilder is reused in the same way the old byte array was. to preserve performance. It solves #712.