Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier pre-commit hook #1438

Closed
wants to merge 1 commit into from
Closed

Add prettier pre-commit hook #1438

wants to merge 1 commit into from

Conversation

klieret
Copy link
Member

@klieret klieret commented Aug 13, 2023

This hook provides standardized formatting for a variety of files, including markdown (where it mostly wraps text) and yaml (I've removed HTML and CSS because it struggled with some custom elements there).

I'd say we want at least some of this, but this also now changes almost every single file, meaning that hanging PRs will most likely yield merge conflicts (that can be resolved by applying this hook there as well).

I'm opening this PR to discuss about this ;)

EDIT: Something still seems to go wrong when applying this in CI

@eduardo-rodrigues
Copy link
Member

Hello @klieret, is this big MR still relevant (especially that we are going to revamp the site) or better close at this point? Advance thanks.

@eduardo-rodrigues
Copy link
Member

Hello @graeme-a-stewart, @hegner, @jouvin, I would be tempted to close this PR at this point. It is massive and with ideas of "upgrading" the site, it seems less relevant.

@graeme-a-stewart
Copy link
Member

Hi @eduardo-rodrigues - I would agree, given the medium term plan to change website technology, a large formatting PR isn't so useful, so let's close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants