Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documents on "HSF Affiliated Projects and Software" and related Guidelines #1595

Merged
merged 14 commits into from
Oct 9, 2024

Conversation

eduardo-rodrigues
Copy link
Member

Document as finalised by Pere and I with community input, and agreed within the SG.

I started a new folder for this, which should become the one for the top-level menu "Projects & Support" on the homepage.

@eduardo-rodrigues
Copy link
Member Author

This is now ready. The only things missing are the links for the AG (to be added once available) and the documents on the guidelines, which will need to be finalised soon and put online as well.

I'm not suggesting that anyone reviews at this time on a Friday. Let's finalise next week.

@eduardo-rodrigues eduardo-rodrigues marked this pull request as ready for review September 27, 2024 16:15
@eduardo-rodrigues
Copy link
Member Author

Kind ping for 1-2 of you to review this MR :-).

Copy link
Member

@hegner hegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor points. Thank you!

projects/affiliated.md Outdated Show resolved Hide resolved
projects/affiliated.md Outdated Show resolved Hide resolved
projects/affiliated.md Outdated Show resolved Hide resolved
hegner and others added 2 commits October 3, 2024 10:59
Co-authored-by: Eduardo Rodrigues <eduardo.rodrigues@cern.ch>
Co-authored-by: Eduardo Rodrigues <eduardo.rodrigues@cern.ch>
@eduardo-rodrigues
Copy link
Member Author

Thanks. Approve when happy. I will wait for a second approval given the importance of the document.

@hegner
Copy link
Member

hegner commented Oct 3, 2024

@eduardo-rodrigues - would have suggested the same - another pair of eyes would be good. I am fine with the current state

@hegner hegner self-requested a review October 3, 2024 09:16
Copy link
Member

@graeme-a-stewart graeme-a-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @eduardo-rodrigues - I made some suggestions here.

Before we accept it seems we need:

  • The guidelines document
  • Updated navbar.ext that links to these documents

projects/affiliated.md Outdated Show resolved Hide resolved
projects/affiliated.md Outdated Show resolved Hide resolved
projects/affiliated.md Outdated Show resolved Hide resolved
projects/affiliated.md Outdated Show resolved Hide resolved
projects/affiliated.md Show resolved Hide resolved
projects/affiliated.md Outdated Show resolved Hide resolved
projects/affiliated.md Show resolved Hide resolved
projects/affiliated.md Outdated Show resolved Hide resolved
projects/affiliated.md Show resolved Hide resolved
@graeme-a-stewart
Copy link
Member

This is now ready. The only things missing are the links for the AG (to be added once available)

It will be /organization/advisory-group.html - see #1597.

@graeme-a-stewart
Copy link
Member

Sorry it took a while to review @eduardo-rodrigues - JuliaHEP was really full-on last week!

@eduardo-rodrigues
Copy link
Member Author

This is now ready. The only things missing are the links for the AG (to be added once available)

It will be /organization/advisory-group.html - see #1597.

Link added.

@eduardo-rodrigues
Copy link
Member Author

Thank you @eduardo-rodrigues - I made some suggestions here.

Before we accept it seems we need:

* The guidelines document

* Updated `navbar.ext` that links to these documents

OK, I added these now :-). There are some details to discuss and I will comment on those shortly ...

@eduardo-rodrigues
Copy link
Member Author

Hi all. I believe I have now done everything expected :-). I hope I got all (cross-)links correct but good that a couple of us check ...

Related to this update, we need to discuss what exactly to do with the tab highlighted below:
image

For now I moved all 3 items to below the line, having the 2 new documents here above the line. This makes sense to me. This being said, the "Member projects" and "How to join as a project" need to be revamped or deleted. Shall we do that in a quick follow-up?

@eduardo-rodrigues eduardo-rodrigues changed the title Add document on "HSF Affiliated Projects and Software" Add documents on "HSF Affiliated Projects and Software" and related Guidelines Oct 8, 2024
@graeme-a-stewart
Copy link
Member

Thanks @eduardo-rodrigues - this is a lot of work!

I pushed a commit that:

  • Fixes navbar links
  • Shortens the overlong titles
  • Fixes a typo

If you are good with that change I think we can merge.

@eduardo-rodrigues
Copy link
Member Author

Many thanks for the careful checks! I see 2 approvals, merging then :-).

@eduardo-rodrigues eduardo-rodrigues merged commit 49ae5b6 into main Oct 9, 2024
3 checks passed
@eduardo-rodrigues eduardo-rodrigues deleted the eduardo-add-affiliated-proposal branch October 9, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants