Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-5452 Show closed stops on map using badge icons #4970

Open
wants to merge 12 commits into
base: v3
Choose a base branch
from
Open

Conversation

sharhio
Copy link
Contributor

@sharhio sharhio commented Mar 12, 2024

Proposed Changes

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@sharhio sharhio marked this pull request as draft March 12, 2024 11:18
Comment on lines 379 to 380
? `icon-icon_stop-temporarily-closed-badge`
: `icon-icon_stop-closed-badge`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which mode does this stop icon represent (the sprite files does not show up in git)?
Another option to handle badges I'm currently exploring with rental stations, is having badges included in the original svg, and activate/color them via css vars. This would decouple the code from knowing where to place the badge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are universal badges for any mode. Grey clock symbol / cross on red background.

@sharhio sharhio marked this pull request as ready for review March 27, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants