Fix frontend issues on resources page #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for zothacks-site-2023 ready!
|
|
Deploy preview for zothacks-site-2023-sanity ready!
|
samderanova
requested review from
ryanluu12345,
alexanderl19 and
tyleryy
and removed request for
ryanluu12345
|
The new window icon looks a bit off. It looks misaligned with the text. tbh maybe just use the whole tag image if it is too hard to do due to deadlines. 
|
tyleryy
suggested changes
Oct 31, 2023
apps/site/src/views/Resources/components/ResourceCard/ResourceCard.module.scss
Show resolved
Hide resolved
apps/site/src/views/Resources/components/ResourceCard/ResourceCard.module.scss
Show resolved
Hide resolved
apps/site/src/views/Resources/components/ResourceCard/ResourceCard.module.scss
Outdated
Show resolved
Hide resolved
…ix/resources-frontend-issues
…zothacks-site-2023 into fix/resources-frontend-issues
|
If we need to merge fast, i'll approve without any changes. |
taesungh
reviewed
Oct 31, 2023
apps/site/src/views/Resources/components/ResourceCard/ResourceCard.module.scss
Show resolved
Hide resolved
apps/site/src/views/Resources/components/ResourceCard/ResourceCard.module.scss
Show resolved
Hide resolved
apps/site/src/views/Resources/components/ResourceCard/ResourceCard.module.scss
Outdated
Show resolved
Hide resolved
apps/site/src/views/Resources/components/ResourceCard/ResourceCard.tsx
Outdated
Show resolved
Hide resolved
taesungh
reviewed
Oct 31, 2023
apps/site/src/views/Resources/components/ResourceCard/ResourceCard.module.scss
Outdated
Show resolved
Hide resolved
tyleryy
previously approved these changes
Oct 31, 2023
- Include `translateZ(0)` when applying transform to drop shadow filter
tyleryy
pushed a commit
that referenced
this pull request
Nov 3, 2023
* update: created getSchedule file * update: synced sanity data with schedule component * feat: update event schema * feat: group events by day * feat: format date ranges * fix: group events by America/Los_Angeles day * fix: event order asc * fix: remove resources from nav --------- Co-authored-by: Tyler Yu <tyleryy@uci.edu> Fix frontend issues on resources page (#103) * fix: backend description text overflow * feat: new ResourceCard component removed unused assets * fix: key prop error * fix: remove unused components * fix: references to unused images * refactor: short-circuit and color fixes * Fix transformed filter glitches for webkit - Include `translateZ(0)` when applying transform to drop shadow filter --------- Co-authored-by: Taesung Hwang <taesungh@uci.edu> fix: title and location mobile alignment (#109) feat: frontend resources section feat: starter packs section removed placeholder config files feat: add day of week to schedule (#110) * feat: add day of week to schedule * fix: replace weekday list with date format * fix: long month and date format update: restore resources link in navbar fix: timezone inconsistencies (#119) * fix: timezone inconsistencies * fix: timezone inconsistencies fix: backend resources grid issue feature: clipboard paper animation (#116) undefined Feature/clipboard animation update (#123) * feature: clipboard paper animation * fix: padding adjustment on date * fix: border radius and page animation update feat: incident response form fix: remove open in new window icon Setup animated countdown on schedule page (#93) * setup: basic framer countdown * fix: removed useRef, changed animation exit value * update: temporarily disabled slide up animation * fix: conditional day render * fix: precompute time * fix: margin for the countdown * update: added loading bar * fix: rename to Loader * feat: time until hacking countdown timer * fix: clipboard styling --------- Co-authored-by: Tyler Yu <tyleryy@uci.edu> Co-authored-by: Alexander Liu <a@alexanderliu.com> fix: match time zones on server and client fix: missing date-fns-tz import (#126) fix: disable page scroll x (#125) refactor: move homepage from views folder to app folder refactor: convert components to arrow functions and reexport feat: devpost fix: changed import path fix: added ease and moved component
samderanova
pushed a commit
that referenced
this pull request
Nov 3, 2023
* feat: svg animation rough draft * update: increase stroke width * update: new svg * update: added timing to opacity * update: switched to animate to create stagger * fix: adjusted timings * fix: timing * fix: more timing adjustments * fix: type issues with initial variant * fix: responsive svg * fix: removed old title svg * fix: added useEffect dep * fix: remove unused imports * fix: adjusted clamp * update: refactored animated title fix: visually hidden title update: refactored animated title Use lined paper vector and remove unnecessary nav (#62) * fix: use lined paper vector and remove unnecessary nav * fix: stick nav bar to top of screen * fix: remove sticky navbar for mobile --------- Co-authored-by: Sam Der <sder@uci.edu> fix: change resources PNGs to SVGs hotfix: heart and star sticker positioning Add ZotHacks Open Graph Properties (#71) * feat: add OG image * fix: use opengraph-image for OG generation Create Sanity resources schema (#91) * feat: resource schema * feat: icon, preview, and color field description update: TikTok logo and improved alt text (#83) * update: TikTok logo and improved alt text * fix: switch to svg version fix: use container spacing for resource page (#79) * fix: use container spacing for resource page * temp: fix row/col setup * remove col div update: remove apply links and mentor section (#89) * update: remove apply links and mentor section * fix: restore apply button, adjust wording * fix: disabled mentor apply button * update: zothacks 2023 * fix: removed extra import * fix: added variant type * fix: changed import path * fix: added ease and moved component * Feature: SVG ZotHacks Title animation * update: created getSchedule file * update: synced sanity data with schedule component * feat: update event schema * feat: group events by day * feat: format date ranges * fix: group events by America/Los_Angeles day * fix: event order asc * fix: remove resources from nav --------- Co-authored-by: Tyler Yu <tyleryy@uci.edu> Fix frontend issues on resources page (#103) * fix: backend description text overflow * feat: new ResourceCard component removed unused assets * fix: key prop error * fix: remove unused components * fix: references to unused images * refactor: short-circuit and color fixes * Fix transformed filter glitches for webkit - Include `translateZ(0)` when applying transform to drop shadow filter --------- Co-authored-by: Taesung Hwang <taesungh@uci.edu> fix: title and location mobile alignment (#109) feat: frontend resources section feat: starter packs section removed placeholder config files feat: add day of week to schedule (#110) * feat: add day of week to schedule * fix: replace weekday list with date format * fix: long month and date format update: restore resources link in navbar fix: timezone inconsistencies (#119) * fix: timezone inconsistencies * fix: timezone inconsistencies fix: backend resources grid issue feature: clipboard paper animation (#116) undefined Feature/clipboard animation update (#123) * feature: clipboard paper animation * fix: padding adjustment on date * fix: border radius and page animation update feat: incident response form fix: remove open in new window icon Setup animated countdown on schedule page (#93) * setup: basic framer countdown * fix: removed useRef, changed animation exit value * update: temporarily disabled slide up animation * fix: conditional day render * fix: precompute time * fix: margin for the countdown * update: added loading bar * fix: rename to Loader * feat: time until hacking countdown timer * fix: clipboard styling --------- Co-authored-by: Tyler Yu <tyleryy@uci.edu> Co-authored-by: Alexander Liu <a@alexanderliu.com> fix: match time zones on server and client fix: missing date-fns-tz import (#126) fix: disable page scroll x (#125) refactor: move homepage from views folder to app folder refactor: convert components to arrow functions and reexport feat: devpost fix: changed import path fix: added ease and moved component * fix: unused asset --------- Co-authored-by: Alexander Liu <a@alexanderliu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preserveAspectRatio=nonefor the backend resource description index card to resolve text overflow issueResourceCardcomponent that combines the API and backend resource card components into one to allow simpler usage and scalability