Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - added countdown section #160

Merged
merged 14 commits into from
Nov 2, 2024
Merged

Feature - added countdown section #160

merged 14 commits into from
Nov 2, 2024

Conversation

Bl20052005
Copy link
Contributor

@Bl20052005 Bl20052005 commented Oct 3, 2024 •
edited by jotalis
Loading

Added countdown section, features including:

  • new countdown timer
  • working curved time progression (with boat graphics)
  • split the feature into three categories: before hacking starts, during hacking, after hacking ends
  • responsive sizing of section

Things which may require more work:

  • consolidating css styles (some inline may be moved to classes)
  • refactoring code into separate components (the code is not very neat as of now)
  • testing on boundary conditions (transitioning between before hacking - hacking start)
  • (more boundaries: when switching between different events)
  • finalize start and end time for hacking (waiting on log)
  • finalize schedule (waiting on log)
  • any other bugs in the program I have not discovered or thought about

@Bl20052005 Bl20052005 linked an issue Oct 3, 2024 that may be closed by this pull request
[2024] Home: Event Countdown #151
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Deploy preview for zothacks-site-2023-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit dc36276

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited
Loading

Deploy preview for zothacks-site-2023 ready!

Name Hack at UCI Site
Preview Visit Preview
Commit cc371a9

IanWearsHat
IanWearsHat reviewed Oct 3, 2024
View reviewed changes
apps/site/src/app/(home)/sections/Countdown/Countdown.module.scss Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/Countdown/Countdown.module.scss Show resolved Hide resolved
apps/site/src/app/(home)/sections/Countdown/Countdown.module.scss Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/Countdown/CountdownClock.module.scss Show resolved Hide resolved
apps/site/src/app/(home)/sections/Countdown/Countdown.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/Countdown/Countdown.module.scss Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/Countdown/Countdown.module.scss Show resolved Hide resolved
apps/site/src/app/(home)/sections/Countdown/Countdown.module.scss Show resolved Hide resolved
apps/site/src/app/(home)/sections/Countdown/Countdown.module.scss Outdated Show resolved Hide resolved
IanWearsHat
IanWearsHat approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@IanWearsHat IanWearsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this Bo

@Bl20052005 Bl20052005 merged commit 2236e7b into main Nov 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanWearsHat IanWearsHat IanWearsHat approved these changes

@waalbert waalbert Awaiting requested review from waalbert

@ofjuneskies ofjuneskies Awaiting requested review from ofjuneskies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2024] Home: Event Countdown
2 participants
@Bl20052005 @IanWearsHat