Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/background petrs #19

Closed
wants to merge 11 commits into from
Closed

Feature/background petrs #19

wants to merge 11 commits into from

Conversation

tyleryy
Copy link
Contributor

@tyleryy tyleryy commented Sep 9, 2023

Overview

Created background for site.

Detailing information

  • used .svg, contrary to the .png asset precedence
  • fixed background-attachment prevents background from moving when user scrolls, in order to support infinite scrolling (otherwise, between repeated angled background images there are empty spaces with no petrs

Addendum

Feel free to correct me in any way. I am not sure if what I am doing is considered correct or standard or whatnot.

Furthermore...

  • the value of the background-position property can be adjusted to our liking
  • we can try to find another way to the images scroll along, instead of being fixed.

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Deploy preview for zothacks-site-2023 ready!

Name Hack at UCI Site
Preview Visit Preview
Commit 4ab4467

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Deploy preview for zothacks-site-2023-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 4ab4467

@samderanova samderanova linked an issue Sep 11, 2023 that may be closed by this pull request
@taesungh
Copy link
Member

Closing in favor of design from #25.

@taesungh taesungh closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background Petrs
3 participants