Fix doctrine repository find() methods not always returning the correct type hints #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2020 17:26
|
After using this build it looks like it doesn't fix the duplicate return type issue as explained in #1422 but it does solve the issue I was referring to in my comment on that issue. |
|
I believe the latest commit now fixes #1422 :) |
skmedix
suggested changes
Apr 17, 2020
|
thanks for this PR, will also comeback here, fixing lost features for API changes ;) |
|
Is there any help needed with this PR? Can we do anything to speed up merging and publishing it? This issue is becoming more and more annoying and fix would be very welcome :) Also I think it would fix issues reappearing in #1401 |
Haehnchen
added a commit
that referenced
this pull request
May 21, 2020
Haehnchen
added a commit
that referenced
this pull request
May 21, 2020
Haehnchen
added a commit
that referenced
this pull request
May 21, 2020
|
I didn't review, but this really needs attention |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure how these classes/extension points work and I don't normally code in Java let alone IntelliJ plugins - but this seems to be working for me 🤷♂ .
It seems like it wasn't resolving class references correctly. Stripping the class identifiers in the signature solves it so the
getSignature()method can find the PHP class and return it as a type hint.Code review would be appreciated as I don't really know what I'm doing 😂
Potential fix for #1422