MusicAppMediaFix: support multiple (user-specified) media apps #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MusicAppMediaFix.mediaApps table lists the names of applications that should receive media key events. This spoon sends the events to the applications that was last active.
brechtm
changed the title
cmsj
requested changes
Aug 7, 2024
| @@ -16,6 +17,9 @@ obj.homepage = "https://github.com/Hammerspoon/Spoons" | |||
| obj.license = "MIT - https://opensource.org/licenses/MIT" | |||
|
|
|||
| obj.eventtap = nil | |||
| obj.appWatcher = nil | |||
| obj.mediaApps = {"Music"} | |||
There was a problem hiding this comment.
This should really have a docstring and be notated as a Variable.
cmsj
requested changes
Aug 7, 2024
| @@ -1,6 +1,7 @@ | |||
| --- === MusicAppMediaFix === | |||
| --- | |||
| --- Override macOS behaviour and send all media keys (play/prev/next) to Music.app | |||
| --- Override macOS behaviour and send all media keys (play/prev/next) to | |||
| --- the last active of a specified list of apps in MusicAppMediaFix.mediaApps | |||
There was a problem hiding this comment.
I would remove in MusicAppMediaFix.mediaApps from this docstring, given the comment below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the commit messages for a description of the purpose of these changes.
I made these for personal use (to replace and improve upon MacMediaKeyForwarder), but if you think these are generally useful, I can update the documentation to prepare this for merging.
@mathsalmi @cmsj