Darker/dimmed backdrop on teams menu #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some extra conditions to ensure that the key value reading is correct regardless of user's keyboard language. With the use of event.code.
Added some extra code to the getKeyFromInputEvent function so keyboard events are read correctly and regardless of user's keyboard language.
|
Would it be possible to make it fade in |
|
Here is what it looks like team-menu.mp4I will look into it tommorow. Please explain better what you meant by "making it fade in" |
|
I meant that the background could slowly dim when selecting the team menu rather than immediatley going dark |
|
I don't think so, because the splash ui's fade is controlled by the play buttons etc |
hsanger
pushed a commit
that referenced
this pull request
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the splash ui's interaction and makes it darker by using the brightness filter when the teams menu is open
