Fixing bounding boxes for infinite implicit functions. #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bounding boxes now work as edges when using `implicit` defined surfaces. This allows the use of infinite surface functions with a finite bounding box to work with operations such as `intersect`. Haskell-Things#412
This test was failing, and the diff between what was expected compared to what was generated looked to be very small changes in vertices, with no meaningful changes to the overall shape.
|
merged in PR #469. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bounding boxes now work as edges when using
implicitdefined surfaces. This allows the use of infinite surface functions with a finite bounding box to work with operations such asintersect.This fixes #412