Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt history roomdb/develorp #1053

Open
wants to merge 71 commits into
base: main
Choose a base branch
from
Open

Prompt history roomdb/develorp #1053

wants to merge 71 commits into from

Conversation

boyakalyani
Copy link

PR for Room database

kalyaniboya and others added 30 commits July 22, 2024 15:21
@kalyaniboya
local commit for kalyani
0480c15
@kalyaniboya
local commit for kalyani
dbcfd9e
@kalyaniboya
local commit for kalyani
880e081
@kalyaniboya
local commit for kalyani
5d5acdd
@kalyaniboya
local commit for kalyani
de43d7b
@kalyaniboya
local commit for kalyani
0b2f5d7
@surajsahani
Change App name
86dcb04
@surajsahani
AI Engine
7e476be
@surajsahani
Merge remote-tracking branch 'origin/feature_ui/develop' into feature…
d3ffefa 
…_aiEngine/develop

# Conflicts:
#	app/build.gradle
@surajsahani
app name changes | ViewModel Handling
e4020db
@surajsahani
viewModel handling
333189f
@surajsahani
AI added | UI improvement
8e1d45f
@surajsahani
Keyboard changes
9a42c5a
@surajsahani
UI improved
48502d0
@kalyaniboya
button ui setup done
50e51ce
@kalyaniboya
setting and drawer items is working fine
b809200
@kalyaniboya
button colors are working fine
c17a6ed
@kalyaniboya
check icon
1029e3c
@kalyaniboya
working fine
841f707
@surajsahani
Added icons in Heliboard
2d51800
@kalyaniboya
onbackpressed is done
6e81be7
@surajsahani
adding ai logo
04d0c37
@kalyaniboya
onbackpressed is done
b95580b
@kalyaniboya
Merge remote-tracking branch 'origin/feature_aiEngine/develop' into f…
d12e44f 
…eature_UIversion1/develop
@surajsahani
Audio Interface| SharedViewModel
4f50701
@kalyaniboya
ui edge cases fixing
3f88ee3
@surajsahani
Merge pull request #3 from navgurukul/feature_aiEngine/develop
027eb76 
Feature ai engine/develop
@surajsahani
Merge remote-tracking branch 'origin/develop' into feature_aiEngine/d…
78cd681 
…evelop
@surajsahani
Merge pull request #2 from navgurukul/feature_UIversion1/develop
f9b1f0d 
PR for New UI changes
@surajsahani
Merge remote-tracking branch 'origin/develop' into feature_aiEngine/d…
6d581f5 
…evelop
kalyaniboya and others added 27 commits August 8, 2024 12:43
@kalyaniboya
recommanded us crash fixed
c905fda
@surajsahani
Merge remote-tracking branch 'origin/develop' into feature_aiEngine/d…
13eebff 
…evelop
@surajsahani
Merge pull request #8 from navgurukul/feature_aiEngine/develop
3fe70dc 
Feature ai engine/develop
@surajsahani
clearning up text after recording finish
a0a7926
@surajsahani
Merge pull request #10 from navgurukul/feature_aiEngine/develop
8084ade 
clearning up text after recording finish
@kalyaniboya
mic permission is done
e2a913e
@surajsahani
Merge pull request #11 from navgurukul/microphone_permission_changes/…
625f4ee 
…develop

mic permission is done
@surajsahani
data class for AI Interaction
b70d1c7
@surajsahani
copy, undo functionalities | stateFlow to LifeData extension
4539f5c
@surajsahani
Merge pull request #12 from navgurukul/bug_fixes_kalyani/develop
969ae06 
recommanded us crash fixed
@surajsahani
Merge remote-tracking branch 'origin/develop' into feature_aiEngine/d…
ea56658 
…evelop
@surajsahani
Merge pull request #13 from navgurukul/feature_aiEngine/develop
8f4688a 
Feature ai engine/develop
@surajsahani
Bus event for communication
48b4450
@surajsahani
Interface for AI output | viewModel optimization
3b54b7a
@surajsahani
Merge pull request #14 from navgurukul/feature_aiEngine/develop
0477d01 
Feature ai engine/develop
@surajsahani
added event communication for keyboard AIProcessed text
1a14747
@surajsahani
Improved UX
1b83566
@surajsahani
Merge pull request #16 from navgurukul/feature_aiEngine/develop
ccf8a4d 
Feature ai engine/develop
@kalyaniboya
unwanted text was removed && internet check permission && navigation …
972c509 
…hiding
@kalyaniboya
QA fixes
c8e9d80
@surajsahani
Merge pull request #19 from navgurukul/new_bug_fixes/develop
8db295a 
unwanted text was removed && internet check permission && navigation …
@surajsahani
removed sharedViewModel
460fb6c
@surajsahani
commenting out active editor
5cae2c6
@surajsahani
Merge pull request #20 from navgurukul/feature_aiEngine/develop
54ba8d9 
Feature ai engine/develop
@kalyaniboya
locally the data was fetching fine
0b7ef0a
@kalyaniboya
room db
2cd1e0c
@kalyaniboya
room db
0294427
@BlackyHawky
Copy link
Contributor

BlackyHawky commented Aug 16, 2024 •
edited
Loading

What is the purpose of this PR? There is no description, no screenshot...

The guideline isn't respected on many points...

Moreover, you add the Material dependency is not wanted as indicated in the Readme (To-do section).

You also add a permission for internet... Not sure everyone agrees with that.

Almost all the files you've created are unlicensed; you've even removed the license from the KeyCode.kt file...

In 10 seconds of code reading, I'm sure this PR will never be merged. 😬

@Helium314
Copy link
Owner

As @BlackyHawky already said, this PR is not following guidelines at all.
It looks like this PR was meant for https://github.com/navgurukul/oscar-ai-keyboard/ where HeliBoard is rebranded and has an MIT license file added (which is rather questionable considering HeliBoard is GPL 3.0 licensed, with just a few Apache 2.0 files).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@boyakalyani @BlackyHawky @Helium314 @kalyaniboya @surajsahani