Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dargwa(Urakhi) layout #1127

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Dargwa(Urakhi) layout #1127

wants to merge 3 commits into from

Conversation

mekegi
Copy link

@mekegi mekegi commented Sep 27, 2024

Added new layout for Dargwa language (urakhi - dialect)

Tested locally
Screenshot from 2024-09-27 13-42-15

Screenshot from 2024-09-27 13-41-59

Screenshot from 2024-09-27 13-40-50

Screenshot from 2024-09-27 13-40-27

@Helium314
Copy link
Owner

Looks good!
One thing though: please only add popup keys to the layout if they really belong to the layout. Letter variations should only be in locale_key_texts.

Remove locale_key_texts for dargwa_urakhi (because its not needed here)
@mekegi
Copy link
Author

mekegi commented Sep 28, 2024

Looks good! One thing though: please only add popup keys to the layout if they really belong to the layout. Letter variations should only be in locale_key_texts.

Yes, agree. I updated the pull request by removing this file.

@Helium314
Copy link
Owner

It's your choice, but I think the other way would make more sense. When the letter variations are bound to the base letter instead of the layout, they will automatically show up on any (custom) layouts for that language.

@mekegi
Copy link
Author

mekegi commented Nov 13, 2024

It's your choice, but I think the other way would make more sense. When the letter variations are bound to the base letter instead of the layout, they will automatically show up on any (custom) layouts for that language.

I understand. But as in Kaytag layout - Urakhi (Dargwa) looks better with separate layout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants