-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve language swipe cycling #656
base: main
Are you sure you want to change the base?
Conversation
Sensitivity 20 is very low for vertical sliding. I am not sure about this approach. Related issue: #255 |
If you swipe downwards, for sure. But anything higher than 4 may not be feasible as well. That said, if you swipe upwards and have only 2 subtypes, it does make sense. |
Low sensitivity kind of fixes the flickering problem. However, it requires more travel distance and, so, more time to type. This is a drawback. To address this trade-off, perhaps we could consider other options, like the ones mentioned in #255, such as switching only one language per swipe or stopping the cycle at the end of the enabled language. This PR is a positive step forward. I'm just curious if there might be an even more optimal solution to this flickering issue. I'm curious if @nach0 has any thoughts on this approach. |
Just some thoughts, haven't read up on the old issues yet. (so some parts below might be outdated) If sensitivity is too high for swipe to be usable, does it also apply to cursor movement? In my opinion a slider is preferable over a bunch of fixed values, because it allows more fine-grained tuning and requires fewer strings, so less work for translators. |
No, only onLanguageSlide() uses the set value. The calculation for the cursor are different and I have no real issue with them.
what a good range would you say it should be? from 1 to 25 ?
@RHJihan I could implement that very easily but I assume people with many subtypes may not be crazy about it so I might have to add another setting. The other solution is more tricky but I think is feasible. Should I pursue both solutions? |
I am unsure about which approach would be better. Or implementing both will be a good decision? I think it will be better than the current situation. However, I use only two subtypes, I cannot give a final though on this. |
replaced options with slider renamed "sensitivity" with "distance"
@RHJihan On a second though I think the 2nd solution is more elegant and renders the first one a bit redundant if there is also a slider for adjusting the sensitivity. In c50acad I've added that functionality as well as the slider ranging from 2 to 18 with a default 10 in between |
Oops, I tried to rename the branch but I did not know it will close this PR. |
works perfectly. loved it |
@Helium314, just wanted to kindly check in on the status of this PR. I know you're busy, but this PR would be a huge update for me. I’d really appreciate it if it could be reviewed when you have a moment. Thank you! |
I've added a setting to adjust the sensitivity of the language swipe/slide gesture distance sensitivity.
The current step value does not work well on some devices like S22+.
Here is the current behavior:
Click to expand
High.mp4
And with the new default Medium option selected:
Click to expand
medium.mp4