forked from ggchiriac/compass
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV-24: Multiple Distributions update #64
Open
lminsl
wants to merge
1
commit into
main
Choose a base branch
from
minjae_distr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lminsl
changed the title
multiple distributions update
DEV-24: multiple distributions update
Nov 22, 2024
issacli-0821
changed the title
DEV-24: multiple distributions update
DEV-24: Multiple distributions update
Nov 23, 2024
issacli-0821
changed the title
DEV-24: Multiple distributions update
DEV-24: Multiple Distributions update
Nov 23, 2024
issacli-0821
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left one comment. Please remove some of the console.logs, and pull/merge from main for your PR
Comment on lines
+34
to
+91
terms: { | ||
'Fall 2024': '1252', | ||
'Spring 2024': '1244', | ||
'Fall 2023': '1242', | ||
'Spring 2023': '1234', | ||
'Fall 2022': '1232', | ||
'Spring 2022': '1224', | ||
'Fall 2021': '1222', | ||
'Spring 2021': '1214', | ||
'Fall 2020': '1212', | ||
}, | ||
|
||
termsInverse: { | ||
'1252': 'Fall 2024', | ||
'1242': 'Fall 2023', | ||
'1232': 'Fall 2022', | ||
'1222': 'Fall 2021', | ||
'1212': 'Fall 2020', | ||
'1244': 'Spring 2024', | ||
'1234': 'Spring 2023', | ||
'1224': 'Spring 2022', | ||
'1214': 'Spring 2021', | ||
}, | ||
|
||
distributionAreas: { | ||
'Social Analysis': 'SA', | ||
'Science & Engineering - Lab': 'SEL', | ||
'Science & Engineering - No Lab': 'SEN', | ||
'Quant & Comp Reasoning': 'QCR', | ||
'Literature and the Arts': 'LA', | ||
'Historical Analysis': 'HA', | ||
'Ethical Thought & Moral Values': 'EM', | ||
'Epistemology & Cognition': 'EC', | ||
'Culture & Difference': 'CD', | ||
}, | ||
|
||
distributionAreasInverse: { | ||
SA: 'Social Analysis', | ||
SEL: 'Science & Engineering - Lab', | ||
SEN: 'Science & Engineering - No Lab', | ||
QCR: 'Quant & Comp Reasoning', | ||
LA: 'Literature and the Arts', | ||
HA: 'Historical Analysis', | ||
EM: 'Ethical Thought & Moral Values', | ||
EC: 'Epistemology & Cognition', | ||
CD: 'Culture & Difference', | ||
}, | ||
|
||
levels: { | ||
'100': '1', | ||
'200': '2', | ||
'300': '3', | ||
'400': '4', | ||
'500': '5', | ||
}, | ||
|
||
gradingBases: ['A-F', 'P/D/F', 'Audit'], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to use these constants?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Proposed Changes
@issacli-0821