Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-24: Multiple Distributions update #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DEV-24: Multiple Distributions update #64

wants to merge 1 commit into from

Conversation

lminsl
Copy link

@lminsl lminsl commented Nov 22, 2024

References

Proposed Changes

  • views.py: changed backend logic to process multiple distribution areas
  • filterSlice.ts: changed FilterState definition to accommodate multiple distribution areas
  • types.d.ts: changed SettingsModalProps definition to handle multiple distribution areas
  • Search.tsx: changed frontend logic to process multiple distribution areas

@issacli-0821

@lminsl lminsl changed the title multiple distributions update DEV-24: multiple distributions update Nov 22, 2024
@issacli-0821 issacli-0821 self-requested a review November 23, 2024 19:39
@issacli-0821 issacli-0821 changed the title DEV-24: multiple distributions update DEV-24: Multiple distributions update Nov 23, 2024
@issacli-0821 issacli-0821 changed the title DEV-24: Multiple distributions update DEV-24: Multiple Distributions update Nov 23, 2024
Copy link
Collaborator

@issacli-0821 issacli-0821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left one comment. Please remove some of the console.logs, and pull/merge from main for your PR

Comment on lines +34 to +91
terms: {
'Fall 2024': '1252',
'Spring 2024': '1244',
'Fall 2023': '1242',
'Spring 2023': '1234',
'Fall 2022': '1232',
'Spring 2022': '1224',
'Fall 2021': '1222',
'Spring 2021': '1214',
'Fall 2020': '1212',
},

termsInverse: {
'1252': 'Fall 2024',
'1242': 'Fall 2023',
'1232': 'Fall 2022',
'1222': 'Fall 2021',
'1212': 'Fall 2020',
'1244': 'Spring 2024',
'1234': 'Spring 2023',
'1224': 'Spring 2022',
'1214': 'Spring 2021',
},

distributionAreas: {
'Social Analysis': 'SA',
'Science & Engineering - Lab': 'SEL',
'Science & Engineering - No Lab': 'SEN',
'Quant & Comp Reasoning': 'QCR',
'Literature and the Arts': 'LA',
'Historical Analysis': 'HA',
'Ethical Thought & Moral Values': 'EM',
'Epistemology & Cognition': 'EC',
'Culture & Difference': 'CD',
},

distributionAreasInverse: {
SA: 'Social Analysis',
SEL: 'Science & Engineering - Lab',
SEN: 'Science & Engineering - No Lab',
QCR: 'Quant & Comp Reasoning',
LA: 'Literature and the Arts',
HA: 'Historical Analysis',
EM: 'Ethical Thought & Moral Values',
EC: 'Epistemology & Cognition',
CD: 'Culture & Difference',
},

levels: {
'100': '1',
'200': '2',
'300': '3',
'400': '4',
'500': '5',
},

gradingBases: ['A-F', 'P/D/F', 'Audit'],

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to use these constants?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants