Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the unmaintained cryptonite with crypton #68

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Replace the unmaintained cryptonite with crypton #68

merged 2 commits into from
Nov 8, 2024

Conversation

gpampara
Copy link
Contributor

@gpampara gpampara commented Nov 8, 2024

This just replaces the deprecated cryptonite with the maintained crypton package. The latter is a fork and is a drop-in replacement.

turboMaCk
turboMaCk approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@turboMaCk turboMaCk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jhrcek
jhrcek requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@jhrcek jhrcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to make ci green

jhrcek
jhrcek approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@jhrcek jhrcek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM. Would you like this to be released as new version to hackage?

@gpampara
Copy link
Contributor Author

gpampara commented Nov 8, 2024 •
edited
Loading

That would be great - would definitely help. Thanks @jhrcek :)

@jhrcek jhrcek merged commit 4b836fc into Holmusk:master Nov 8, 2024
11 checks passed
@gpampara gpampara deleted the crypton branch November 8, 2024 12:53
@jhrcek
Copy link
Contributor

jhrcek commented Nov 8, 2024

Ok, published as https://hackage.haskell.org/package/servant-hmac-auth-0.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrcek jhrcek jhrcek approved these changes

@turboMaCk turboMaCk turboMaCk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpampara @jhrcek @turboMaCk