yt-dlp support #31
Open
yt-dlp support #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hizkifw
reviewed
Mar 25, 2023
| @@ -88,6 +89,7 @@ pub struct ChannelConfig { | |||
| pub outpath: String, | |||
| /// If not present, will be fetched during runtime. | |||
| pub picture_url: Option<String>, | |||
| pub recorder: String, // TODO: Check this is a valid recorder on config load. | |||
There was a problem hiding this comment.
I think it'd be better if you make an enum instead of using a string here
| .ok_or(anyhow!("Failed to get filename"))?; | ||
| let destpath = Path::new(&task.output_directory).join(filename); | ||
|
|
||
| // Try to rename the file into the output directory |
There was a problem hiding this comment.
I think this rename-otherwise-copy logic can be pulled out to a separate utility module
| video_status: VideoStatus, | ||
| } | ||
|
|
||
| impl YTDOutputParser { |
There was a problem hiding this comment.
Since ytarchive and yt-dlp uses a similar method to parse the command line output, I think it'd be good if you can create an OutputParser trait, so both YTDOutputParser and YTAOutputParser shares the same interface.
| return; | ||
| } | ||
|
|
||
| let waiting_text = "[wait] Remaining time until next attempt:"; // Does it make sense to have this as a variable? Move to constant? |
There was a problem hiding this comment.
I think it's fine, it'll (probably) get optimized into a constant anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation supporting yt-dlp as a recorder. I'm fairly new to Rust so I may be doing some silly things.
I want to add some tests and move the shared logic from the
recordfunction. Everything works from my testing. I'll need to do a bit more, before I'm confident in the yt-dlp side.