Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New setting watchViewReversed to place chat on the left #659

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

New setting watchViewReversed to place chat on the left #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/locales/en/ui.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,8 @@ views:
title: Settings
darkModeLabel: Dark Mode
darkModeMsg: Changes the theme between light mode and dark mode
watchViewReversedLabel: Show Chat on Left
watchViewReversedMsg: Display chat to left of screen in watch screen
redirectModeLabel: Open on Youtube
redirectModeMsg: >-
Clicking on video thumbnails will open it in Youtube, clicking the video
Expand Down
2 changes: 2 additions & 0 deletions src/store/settings.module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ const initialState = {
ignoredTopics: [],
// Valid values: "grid" | "list" | "denseList"
homeViewMode: "grid",
watchViewReversed: false,

// Live TL Window Settings
liveTlStickBottom: false,
Expand Down Expand Up @@ -118,6 +119,7 @@ const mutations = {
"liveTlHideSpoiler",
"hidePlaceholder",
"homeViewMode",
"watchViewReversed",
]),
resetState(state) {
Object.assign(state, initialState);
Expand Down
10 changes: 10 additions & 0 deletions src/views/Settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,15 @@
:prepend-icon="mdiWeatherNight"
/>
<!-- :messages="$t('views.settings.darkModeMsg')" -->
<v-switch
v-model="watchViewReversed"
class="v-input--reverse v-input--expand"
:label="$t('views.settings.watchViewReversedLabel')"
hide-details
inset
:prepend-icon="mdiWeatherNight"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what icon is appropriate here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps mdiFlipHorizontal? You can search through the material design icons on sites like https://mdisearch.com/.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also suggest changing the watch button to represent the direction the chat dock will happen in mdiDockLeft vs mdiDockRight

/>
<!-- :messages="$t('views.settings.watchViewReversedMsg')" -->
<div class="mt-6">
<v-icon style="margin-right: 9px">
{{ mdiPalette }}
Expand Down Expand Up @@ -319,6 +328,7 @@ export default {
"autoplayVideo",
"scrollMode",
"defaultOpen",
"watchViewReversed",
]),
currentCol() {
if (this.$vuetify.breakpoint.smAndDown) return 12;
Expand Down
4 changes: 3 additions & 1 deletion src/views/Watch.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
'theater-mode': video.type === 'stream' || $vuetify.breakpoint.mdAndDown,
'show-chat': showChatWindow,
'full-height': theaterMode,
'show-highlights-bar': showHighlightsBar
'show-highlights-bar': showHighlightsBar,
'flex-row-reverse': watchViewReversed,
}"
>
<KeyPress
Expand Down Expand Up @@ -214,6 +215,7 @@ export default {
computed: {
...mapState("watch", ["video", "isLoading", "hasError"]),
...syncState("watch", ["showTL", "showLiveChat", "theaterMode"]),
...syncState("settings", ["watchViewReversed"]),
chatStatus: {
get() {
return {
Expand Down