Add "Starts" before dates for future streams to differentiate from past streams #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st streams This change only affects streams starting in more than 23 hours (which display dates instead of relative time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only affects streams starting in more than 23 hours (which display dates instead of relative time), bringing some consistency in how future streams are displayed vs past streams by including the (localized) "Starts" prefix for all future streams instead of only near-future ones.
I believe this also works correctly in other languages without looking too strange, but would like verification from experts on that.
Also slightly cleans up formatDistance.
Screenshots (first video in each has the updated behavior):
