Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul current path reconstruction in eager execution #1205

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Overhaul current path reconstruction in eager execution #1205

merged 7 commits into from
Sep 23, 2024

Commits on Sep 11, 2024

  1. Tentatively fix macro function's child scope reconstruction

    @jasmith-hs
    jasmith-hs committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9636a6e View commit details
    Browse the repository at this point in the history

  2. Add test that tests bug seen in production, where the current_path after 

    macro function executed with nested interpretation was not preserved.
With this change, by wrapping the output in a child scope, the
current_path is preserved
    @jasmith-hs
    jasmith-hs committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    84567ed View commit details
    Browse the repository at this point in the history

  3. Update tests to expect child scope reconstruction for partially 

    evaluated macro output
    @jasmith-hs
    jasmith-hs committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    47b4258 View commit details
    Browse the repository at this point in the history

  4. Use the strategy of setting a temp variable to wrap current_path instead

    @jasmith-hs
    jasmith-hs committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c0706d0 View commit details
    Browse the repository at this point in the history

  5. Add new class to consider temp variables for the purpose of preserving 

    state to be meta context variables. Update var names to be consistent
and update usages
    @jasmith-hs
    jasmith-hs committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f9b6855 View commit details
    Browse the repository at this point in the history

  6. Remove unused variable

    @jasmith-hs
    jasmith-hs committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d0f329e View commit details
    Browse the repository at this point in the history

  7. Don't cause set tags for current_path to disappear in nested 

    interpretation
    @jasmith-hs
    jasmith-hs committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    bc15907 View commit details
    Browse the repository at this point in the history