Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/algorithms/test_sqil.py::test_sqil_performance_continuous[DDPG] failure #791

Closed
ZiyueWang25 opened this issue Oct 1, 2023 · 1 comment · Fixed by #811
Closed
Labels
bug Something isn't working

Comments

@ZiyueWang25
Copy link
Contributor

ZiyueWang25 commented Oct 1, 2023

Bug description

>       assert reward_improvement.is_significant_reward_improvement(
            rewards_before,  # type:ignore[arg-type]
            rewards_after,  # type:ignore[arg-type]
        )
E       assert False
E        +  where False = <function is_significant_reward_improvement at 0x135cafdc0>([-1379.139569, -1592.006733, -1771.549952, -1345.075819, -1701.436911, -1223.385152, ...], [-1331.957287, -1518.792578, -1274.336042, -1294.565801, -1089.05092, -1652.311479, ...])
E        +    where <function is_significant_reward_improvement at 0x135cafdc0> = reward_improvement.is_significant_reward_improvement

Relevant CircleCI link: https://app.circleci.com/pipelines/github/HumanCompatibleAI/imitation/3903/workflows/84d03683-66fc-416e-865a-27bb86d78349/jobs/15818

Steps to reproduce

Directly run at master head.
pytest tests/algorithms/test_sqil.py::test_sqil_performance_continuous[DDPG]

@ZiyueWang25 ZiyueWang25 added the bug Something isn't working label Oct 1, 2023
@ZiyueWang25
Copy link
Contributor Author

It was found out in #779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant