-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQIL and PC performance check fixes #811
Conversation
b1b1f13
to
1b20336
Compare
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 95.67% 95.63% -0.05%
==========================================
Files 100 100
Lines 9581 9582 +1
==========================================
- Hits 9167 9164 -3
- Misses 414 418 +4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @AdamGleave would you review and merge? The coverage went down since I disabled the SQIL performance tests for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for the slow review. If I'm blocking something feel free to either ping me or get someone else to review (can start asking @dan-pandori for example).
Description
Fixes #807
Fixes #791
Testing
Changes are covered by the existing tests.