Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVO-972] Add Translations #1385

Merged
merged 78 commits into from
May 12, 2023
Merged

[EVO-972] Add Translations #1385

merged 78 commits into from
May 12, 2023

Conversation

Sofacosta
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Patch coverage: 48.62% and project coverage change: -0.06 ⚠️

Comparison is base (ae4d462) 46.69% compared to head (fdb69cc) 46.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1385      +/-   ##
==========================================
- Coverage   46.69%   46.63%   -0.06%     
==========================================
  Files         560      565       +5     
  Lines       12940    13183     +243     
  Branches     3727     3762      +35     
==========================================
+ Hits         6042     6148     +106     
- Misses       6898     7035     +137     
Impacted Files Coverage Δ
src/components/BadgeEmoji/BadgeEmoji.js 0.00% <0.00%> (ø)
src/components/GroupsSelector/GroupsSelector.js 8.57% <0.00%> (ø)
...yloEditor/extensions/suggestions/SuggestionList.js 0.00% <0.00%> (ø)
src/components/IconSelector/IconSelector.js 12.50% <0.00%> (-1.79%) ⬇️
src/components/Map/EditableMap/EditableMapModal.js 16.66% <0.00%> (-3.34%) ⬇️
src/components/Map/NativeTerritoriesLayers.js 0.00% <0.00%> (ø)
src/components/PostBigGridItem/PostBigGridItem.js 0.00% <0.00%> (ø)
src/components/PostCard/EventBody/EventBody.js 0.00% <0.00%> (ø)
src/components/PostCard/PeopleInfo/PeopleInfo.js 0.00% <0.00%> (ø)
src/components/PostCard/PostFooter/PostFooter.js 100.00% <ø> (ø)
... and 144 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@lorenjohnson lorenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good✨

Remind me that we should talk about Suspense. You won't have any trouble in dev, but we may need to merge a related branch I have which supports it server-side (due to out server-side rendering setup). No stress if you don't follow entirely, just flagging this for now.

@lorenjohnson
Copy link
Member

Here is the branch we'll need so that Suspense works once this is deployed to staging or production: #1322

Copy link
Contributor

@tibetsprague tibetsprague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just starting to go through but have some comments to start with

public/locales/es/translation.json Outdated Show resolved Hide resolved
public/locales/es/translation.json Outdated Show resolved Hide resolved
public/locales/es/translation.json Outdated Show resolved Hide resolved
public/locales/es/translation.json Outdated Show resolved Hide resolved
public/locales/es/translation.json Outdated Show resolved Hide resolved
public/locales/es/translation.json Outdated Show resolved Hide resolved
public/locales/es/translation.json Outdated Show resolved Hide resolved
public/locales/es/translation.json Outdated Show resolved Hide resolved
public/locales/es/translation.json Outdated Show resolved Hide resolved
public/locales/es/translation.json Outdated Show resolved Hide resolved
@lorenjohnson lorenjohnson temporarily deployed to hylo-evo-staging May 1, 2023 23:44 Inactive
@lorenjohnson lorenjohnson temporarily deployed to hylo-evo-staging May 2, 2023 00:10 Inactive
@lorenjohnson lorenjohnson temporarily deployed to hylo-evo-staging May 2, 2023 03:09 Inactive
@tibetsprague
Copy link
Contributor

/Users/tibet/Dev/hylo/hylo-evo/src/routes/NonAuthLayoutRouter/util.js has a translation TODO in it

@lorenjohnson lorenjohnson temporarily deployed to hylo-evo-staging May 3, 2023 21:44 Inactive
@lorenjohnson lorenjohnson temporarily deployed to hylo-evo-staging May 3, 2023 21:47 Inactive
@tibetsprague
Copy link
Contributor

Found bug: try going to group explorer and selecting Farms and then clicking on the Filters - it crashes saying Error: Rendered more hooks than during the previous render.

@tibetsprague
Copy link
Contributor

Bug: the Create Role button says t('Create Role')

@lorenjohnson lorenjohnson temporarily deployed to hylo-evo-staging May 8, 2023 17:41 Inactive
@lorenjohnson lorenjohnson temporarily deployed to hylo-evo-staging May 8, 2023 20:22 Inactive
@thomasgwatson
Copy link
Collaborator

This function relies on an english language string to detect if its an error or not... that's not going to be reliable going forward. I am leaving this as a todo for #1498

@tibetsprague
Copy link
Contributor

The current sort value in the sort options dropdown for the stream is not translated. The options are but the current option is always in english

@tibetsprague
Copy link
Contributor

Found a little broken spot: go to a User's profile and change the dropdown from Overview to Posts and it says "{{name}}s posts". (Also the posts don't load but thats a separate bug which i have filed)

@tibetsprague
Copy link
Contributor

Mousing over the visibility setting icon for a group in the group about info on the group explorer is showing this partially translated text: "Público - Anyone can find and see this group"

@tibetsprague
Copy link
Contributor

The text "just now" when showing the timestamp in DMs is untranslated, which is related to datetimes in general

@tibetsprague
Copy link
Contributor

On the notifications settings page the text On and Off is not translated, and neither are the tooltips when hovering over the On/Off buttons

@lorenjohnson lorenjohnson temporarily deployed to hylo-evo-staging May 12, 2023 17:34 Inactive
@tibetsprague tibetsprague merged commit 114ae83 into dev May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants