-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EVO-972] Add Translations #1385
Conversation
…p allowing it to code-split with minimum dependencies
…editor-performance
…editor-performance
…obile-editor-performance
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #1385 +/- ##
==========================================
- Coverage 46.69% 46.63% -0.06%
==========================================
Files 560 565 +5
Lines 12940 13183 +243
Branches 3727 3762 +35
==========================================
+ Hits 6042 6148 +106
- Misses 6898 7035 +137
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good✨
Remind me that we should talk about Suspense
. You won't have any trouble in dev, but we may need to merge a related branch I have which supports it server-side (due to out server-side rendering setup). No stress if you don't follow entirely, just flagging this for now.
Here is the branch we'll need so that Suspense works once this is deployed to staging or production: #1322 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just starting to go through but have some comments to start with
/Users/tibet/Dev/hylo/hylo-evo/src/routes/NonAuthLayoutRouter/util.js has a translation TODO in it |
Found bug: try going to group explorer and selecting Farms and then clicking on the Filters - it crashes saying Error: Rendered more hooks than during the previous render. |
Bug: the Create Role button says t('Create Role') |
This function relies on an english language string to detect if its an error or not... that's not going to be reliable going forward. I am leaving this as a todo for #1498 |
The current sort value in the sort options dropdown for the stream is not translated. The options are but the current option is always in english |
Found a little broken spot: go to a User's profile and change the dropdown from Overview to Posts and it says "{{name}}s posts". (Also the posts don't load but thats a separate bug which i have filed) |
Mousing over the visibility setting icon for a group in the group about info on the group explorer is showing this partially translated text: "Público - Anyone can find and see this group" |
The text "just now" when showing the timestamp in DMs is untranslated, which is related to datetimes in general |
On the notifications settings page the text On and Off is not translated, and neither are the tooltips when hovering over the On/Off buttons |
No description provided.