Add error details for failed container start: Fixes #215

Hyperfoil · Jul 9, 2024 · e59dbc3 · e59dbc3
1 parent 9da3391
commit e59dbc3
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/main/java/io/hyperfoil/tools/qdup/shell/ContainerShell.java b/src/main/java/io/hyperfoil/tools/qdup/shell/ContainerShell.java
@@ -96,7 +96,11 @@ PrintStream connectShell() {
                     //TODO how to fail when container start fails
                 }else{
                     containerId = shell.shSync(populatedCommand,null,connectTimeoutSeconds);
-                    if(containerId.contains("\n") || containerId.isBlank()){
+                    if(containerId.contains("Error:") || containerId.isBlank()){
+                        //there was an error reported from container runtime
+                        logger.error("error starting {} container {} : {}",getHost().isLocal() ? "local" : "remote", getHost().getSafeString(), containerId);
+                        return null;
+                    } else if(containerId.contains("\n") || containerId.isBlank()){
                         //assume the container started connected
                         //cannot shSync because connection is not ready...
                         rtrn = shell.commandStream;