Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare for #127 and #56 #179

Closed
wants to merge 14 commits into from
Closed

prepare for #127 and #56 #179

wants to merge 14 commits into from

Conversation

SamYuan1990
Copy link
Member

@SamYuan1990 SamYuan1990 commented Jul 3, 2021 •
edited
Loading

  1. Add crypto interface as prepare for Does this project support fabric-gm? #127
  2. Add Worker interface for Test peer/orderer **separately** #56 and decouple Assembler and Integrator, Broadcasters and Proposers
  3. Some package refactor

Signed-off-by: Sam Yuan yy19902439@126.com

@SamYuan1990 SamYuan1990 marked this pull request as draft July 3, 2021 12:09
@SamYuan1990 SamYuan1990 force-pushed the ArchRefactor branch 3 times, most recently from 34d9664 to 3e90f4f Compare July 3, 2021 15:50
@SamYuan1990 SamYuan1990 marked this pull request as ready for review July 3, 2021 16:44
@SamYuan1990 SamYuan1990 requested a review from wuxuer July 3, 2021 16:44
guoger
guoger requested changes Jul 4, 2021
View reviewed changes
Copy link
Member

@guoger guoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr is fairly large. let's do a code walk-through on Tue

@SamYuan1990
add crpto interface as repare for Hyperledger-TWGC#127
84edd43 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
adding Worker interface for Hyperledger-TWGC#56 and decouple Assemble…
58a2cf7 
…r and Integrator

Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
refactor for worker interface
bdd8aff 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
package structure
8fa0a8c 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
fix up
c7aa94e 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990 SamYuan1990 marked this pull request as draft July 18, 2021 11:35
@SamYuan1990
package refactor
1e33a9d 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
fix up
69208c0 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
fix up
bbc9d77 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
remove Envelope from elements
71de2df 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
add memeory free
74c90ef 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
remove Proposal from Elements
f703b38 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
fix up
264f662 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
move start time to ctx
d55f04d 
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990 SamYuan1990 marked this pull request as ready for review July 18, 2021 14:44
@stale
Copy link

stale bot commented Aug 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 17, 2021
@davidkhala davidkhala removed the stale label Aug 20, 2021
@stale
Copy link

stale bot commented Oct 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 1, 2021
@stale stale bot closed this Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoger guoger guoger requested changes

@yiwenlong yiwenlong Awaiting requested review from yiwenlong

@wuxuer wuxuer Awaiting requested review from wuxuer

Assignees
No one assigned
Labels
stale
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamYuan1990 @guoger @davidkhala