Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --prometheus-addr option #295

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

geekya215
Copy link
Contributor

This enhancement expands the Prometheus integration capabilities by introducing the --prometheus-addr option, which enables users to specify a custom address for the Prometheus service.

The following example shows tape how to start the Prometheus service on port 9090 with --prometheus-addr option

./tape --config=config.yaml --number=40000 --prometheus --prometheus-addr :9090

If user does not enable Prometheus service but specify service address

./tape --config=config.yaml --number=40000 --prometheus-addr :9090

tape will give user this help message You've provided the --prometheus-addr option to specify a Prometheus address, but you haven't enabled Prometheus using --prometheus option

This feature doesn't disrupt existing functionality. It's backward-compatible, so projects using the traditional --prometheus option on the default :8080 address will continue to work as expected.

Signed-off-by: Lin Yang <geekya215@gmail.com>
cmd/tape/main.go Outdated Show resolved Hide resolved
Copy link
Member

@SamYuan1990 SamYuan1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestion on logging is commented, please take a look at.

Signed-off-by: Lin Yang <geekya215@gmail.com>
@geekya215
Copy link
Contributor Author

I've added logs for prometheus service, please review. @SamYuan1990

Copy link
Member

@SamYuan1990 SamYuan1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamYuan1990 SamYuan1990 merged commit 6c36004 into Hyperledger-TWGC:master Aug 14, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants