Fix missing API calls #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inting success message
MartinSalinas98
approved these changes
Sep 24, 2024
|
Btw: SonarCloud has had a major outage this morning, and, while they are back up now, they don't seem to have received the code scanning request from this PR. Try pushing any dummy commit to trigger a rescan before this gets merged. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some API calls could not finish since the connection was closed after creating it.
We have had a new line to get the server response and then close the connection. In addition, we have added a timeout of 2 seconds on the client side.
Finally, we have implemented the API call-sending process before printing the finished message to avoid user misunderstandings.