Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Settings #818

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

More Settings #818

wants to merge 6 commits into from

Conversation

Razer1724
Copy link

@Razer1724 Razer1724 commented Oct 14, 2024

Description

Just more settings people can mess with. (Fixed the super long commits history)

Motivation and Context

Wanted to add more settings.

How has this been tested?

Works on my pc

Screenshots (if appropriate):

New_Settings
New_Settings_more

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@blaisewf
Copy link
Member

Still missing what I said on the other PR, pass the arguments via CLI not editing the jsons. Also, just the significant options

@Razer1724
Copy link
Author

Ok, i tried making it so its sent by CLI but it just doesnt work idk why but i cant figure it out maybe im just not smart enough or maybe i just dont see it. Some help would be greatly appreciated. Also whats wrong with just editing the json? Would it decrease performance or would it just make the code to complicated/bloated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants