Téléchargement carte 56 #62

Naminoshin · 2024-10-08T12:49:53Z

Description

This PR introduces l'affichage d'une fenêtre modale lorsque l'on click sur la partie téléchargement. Cette fenêtre contient un bouton permettant de revenir en arrière.

Architectural changes

The following library now depends on [...]

Screenshots

[...]

Quality Assurance Checklist

Commit history is devoid of any merge commits and readable to facilitate reviews
If new logic ⚙️ is introduced: unit tests were added
If new user stories 🤏 are introduced: E2E tests were added
If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
If breaking changes 🪚 are introduced: add the breaking change label
If bugs 🐞 are fixed: add the backport <release branch> label
The documentation website 📚 has received the love it deserves

This work is sponsored by Organization ABC.

…urus

this component will be used in the geographical coverage as well

Tests are moved to ng-mocks for convenience

This required adding TranslateModule to some tests in return

This fixes an issue where we can't match a deleted keywords with the array of shown keywords because the array would be recreated on each subscription The generic-keywords component is also not mutating its input array (this was causing a bug as well)

…es-ui [ME] UI components for attached resources

…yarn/micromatch-4.0.8 chore(deps): bump micromatch from 4.0.5 to 4.0.8

…error ME: fix a bug when clicking "back" after creating a record would cause an error

[ME] spatial extents field

ME: draft rollback

…with-dashboard-views [ME]: Fix misc issues with dashboard view

Update communication options with geonetwork-ui user forum

Metadata Editor: redirect to login URL if accessing the editor as anonymous user

…stributions ME: edit record distributions

…ement #56

…sur un lien de téléchargement #56

github-actions · 2024-10-08T12:51:21Z

Affected libs: api-metadata-converter, api-repository, feature-catalog, feature-record, feature-router, feature-editor, feature-search, feature-map, feature-dataviz, feature-auth, ui-search, common-domain, common-fixtures, util-shared, ui-elements, feature-notifications, ui-catalog, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz, database-dump, data-access-datafeeder, util-data-fetcher, util-app-config, data-access-gn4, util-i18n,
Affected apps: datahub, metadata-converter, metadata-editor, demo, webcomponents, search, map-viewer, datafeeder, data-platform,

🚀 Build and deploy storybook and demo on GitHub Pages
📦 Build and push affected docker images

github-actions · 2024-10-08T12:57:45Z

📷 Screenshots are here!

vsasyan-ignf

ok pour moi dans la forme, après pour le fond je te laisse voir avec Mélodia.

mmohadIGN · 2024-10-16T11:56:53Z

@Naminoshin Il ne faut pas faire de pr sur la branch datahub mais sur la branch api_téléchargement_mvp. Est-ce que tu peux faire le changement ?

mmohadIGN · 2024-10-16T11:58:37Z

apps/datahub/src/app/record/record-apis/record-apis.component.html

  >
  </gn-ui-api-card>
 </gn-ui-carousel>
 <div
+  *ngIf="displayLayer"


Plutot que displayLayer, je pense qu'il serait pertinent de mettre une variavle qui fait sens. Par exemple carteLayer ou downloadCarteLayer

mmohadIGN · 2024-10-16T11:59:19Z

apps/datahub/src/app/record/record-apis/record-apis.component.ts

@@ -18,9 +18,10 @@ import { CarouselComponent } from '@geonetwork-ui/ui/layout'
 export class RecordApisComponent implements OnInit {
  @ViewChild(CarouselComponent) carousel: CarouselComponent

-  maxHeight = '0px'
-  opacity = 0
+  maxHeight = '700px'


Est-ce qu'on peut passer en pourcentage plutôt que px ? j'ai peur que ça ne soit pas responsive

mmohadIGN · 2024-10-16T12:00:04Z

apps/datahub/src/app/record/record-apis/record-apis.component.ts

+  }
+
+  openModalLayer(link: DatasetServiceDistribution) {
+    console.log('je suis laa haut')


A supprimer

…ment d'une donnée

jahow and others added 30 commits August 26, 2024 13:44

feat(inputs): improvements to image-input similar to file-input

1e99f74

chore: i18n

c530006

feat(platform): better keyword mapping, include bbox

4c358e6

feat(platform): add a method for searching a keyword in a given thesa…

77758b5

…urus

feat(editor): separate component for keyword editing

b1f8e96

this component will be used in the geographical coverage as well

feat(editor): add spatial extent form field

c7bcaa4

feat(editor): add spatial extents field to record form

27a14e7

Tests are moved to ng-mocks for convenience

chore(me): use ng-mocks in tests

487e640

chore(ui): add export of switch-toggle component

79d6456

feat(me): add ol.css

14bf4d1

feat(editor): show a warning when a place keyword does not have a bbox

f5a3a0c

chore: i18n

4dd2152

chore(ui-map): fix wrong import messing up translations

11c27b9

This required adding TranslateModule to some tests in return

fix(converter): properly write and read spatial extents in XML

ebe9333

Merge pull request geonetwork#970 from geonetwork/ME-attached-resourc…

a7c0c75

…es-ui [ME] UI components for attached resources

Merge pull request geonetwork#973 from geonetwork/dependabot/npm_and_…

e7ff1d2

…yarn/micromatch-4.0.8 chore(deps): bump micromatch from 4.0.5 to 4.0.8

fix(me): back button goes to search after record creation

4a4ec1d

Merge pull request geonetwork#975 from geonetwork/me-fix-create-back-…

10a614b

…error ME: fix a bug when clicking "back" after creating a record would cause an error

Apply PR comments

a9aa234

Merge pull request geonetwork#941 from geonetwork/ME-geographical-extent

a6f221e

[ME] spatial extents field

feat(editor): add undo to the editor facade

e393ac5

feat(editor): refresh each form field on record restore

a995a57

e2e(editor): undo

6d40aa2

chore(editor): i18n

cfaafc5

Merge pull request geonetwork#966 from geonetwork/ME/draft-rollback

7a893ad

ME: draft rollback

detect that record was never saved + change canDelete name

1722354

fix dashboard not loading all records

4876122

change canDelete name (now used beyond this scope)

e4734e0

display new columns names and data

6a5058b

jahow and others added 14 commits September 26, 2024 09:33

docs: improve root README a bit more

4c45974

Merge pull request geonetwork#990 from geonetwork/me-fix-misc-issues-…

f501972

…with-dashboard-views [ME]: Fix misc issues with dashboard view

docs: improve project introduction, mention communication channels

43f0d6f

Merge pull request geonetwork#1005 from geonetwork/forum

4892c30

Update communication options with geonetwork-ui user forum

feat(me): redirect to login if needed

9817a80

docs: mention xsrf issue in faq

c95043b

Merge pull request geonetwork#1006 from geonetwork/me-redirect-to-login

be95197

Metadata Editor: redirect to login URL if accessing the editor as anonymous user

feat(editor): record distribution as online resources

84ef5d8

e2e(me): fix edit test

177e6ab

Merge pull request geonetwork#1002 from geonetwork/ME/record-field-di…

fdf8f64

…stributions ME: edit record distributions

ajout filtre organization

b85e6b1

Merge branch 'main' into datahub-ign-2905

74fab3f

feat(formapi): Ajout d'une fenêtre modale pour la partie de télécharg…

1329102

…ement #56

feat(formapi): Finalisation de la fenêtre modale lorsque l'on appuis …

13a8211

…sur un lien de téléchargement #56

Naminoshin requested review from mmohadIGN and vsasyan-ignf October 8, 2024 12:49

Naminoshin changed the base branch from main to Api_telechargement October 8, 2024 12:53

Naminoshin changed the base branch from Api_telechargement to datahub-ign-2905 October 8, 2024 12:53

feat(formapi): Modification de la denêtre modale

d37aa48

vsasyan-ignf reviewed Oct 8, 2024

View reviewed changes

feat(formapi): Nettoyage du code

3b00b75

Naminoshin changed the base branch from datahub-ign-2905 to api_telechargement_mvp October 21, 2024 08:30

Naminoshin requested a review from vsasyan-ignf October 21, 2024 08:40

mmohadIGN requested changes Oct 21, 2024

View reviewed changes

mmohadIGN assigned Naminoshin Oct 30, 2024

feat(MapModal): Ajout d'une modale lors d'un sur la partie télécharge…

a35ddcc

…ment d'une donnée

Naminoshin requested a review from mmohadIGN November 5, 2024 12:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Téléchargement carte 56 #62

Téléchargement carte 56 #62

Naminoshin commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

vsasyan-ignf left a comment

mmohadIGN commented Oct 16, 2024

mmohadIGN Oct 16, 2024

mmohadIGN Oct 16, 2024

mmohadIGN Oct 16, 2024

Téléchargement carte 56 #62

Are you sure you want to change the base?

Téléchargement carte 56 #62

Conversation

Naminoshin commented Oct 8, 2024 • edited Loading

Description

Architectural changes

Screenshots

Quality Assurance Checklist

github-actions bot commented Oct 8, 2024 • edited Loading

github-actions bot commented Oct 8, 2024 • edited Loading

vsasyan-ignf left a comment

Choose a reason for hiding this comment

mmohadIGN commented Oct 16, 2024

mmohadIGN Oct 16, 2024

Choose a reason for hiding this comment

mmohadIGN Oct 16, 2024

Choose a reason for hiding this comment

mmohadIGN Oct 16, 2024

Choose a reason for hiding this comment

Naminoshin commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading