Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add task type endpoint #650

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Add task type endpoint #650

merged 3 commits into from
Aug 4, 2023

Conversation

anarute
Copy link
Member

@anarute anarute commented Jul 20, 2023

  • Add services layer in the API
  • Start fetching the Task Types from the API instead of having them hardcoded

@anarute anarute requested a review from dmtrek14 July 20, 2023 15:51
@anarute
Add task type endpoint
6a58289 
- Create the services layer that will be responsible to access the
database.

- Add get task types endpoints
@anarute
Add makeAPIRequest method
6716ad9 
It will be used to make requests
to the new API
@anarute
Start fetching task types from the API
6bd31e6 
Instead of having them hardcoded
dmtrek14
dmtrek14 reviewed Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@dmtrek14 dmtrek14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have the one question about the successful response in getTaskTypes.php (see comment above).

web/services/getTaskTypes.php Show resolved Hide resolved
@anarute anarute merged commit e4c5e41 into main Aug 4, 2023
1 check passed
@anarute anarute deleted the add-task-type-endpoint branch August 4, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmtrek14 dmtrek14 dmtrek14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anarute @dmtrek14