Add support for development environment with docker #659
Conversation
anarute
commented
Aug 16, 2023
•
anarute
commented
- Add images for all 3 apps: current phpreport app, react front end and the new API.
- Add several minor fixes in other for the apps to work in this environment and the frontend work well after the refresh token logic was added
There should be no whitespace between the groups or they will be added in the group name.
Not every provider uses the same prop, so better to make this configurable.
After the refresh token logic was added, the access token is the one valid in the API
There was a problem hiding this comment.
I have a nit (in the dev.app.Dockerfile) and some thoughts on additions to the docs for running with this new setup.
And one more general comment/question: In the dev docker compose, we are not setting up a volume for the database, which will be fine in a lot of cases, but I could see someone also wanting to persist data during development. Should we change the docker compose to have a volume for the data? Maybe commented out so that if someone wants to persist data, all they need to do is uncomment a couple things? If that's something we want to do, then we should also make note of it in the documentation.
By default the postgresql image already creates an anonymous volume, but that's a good point, I'll add it to make it more explicit, good catch! |
Add files for the 3 apps: phpreport legacy, the front end and the API. Also spawns a postgres container with initial data.
This way it can be accessible when running the app with docker
