-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Vite project with NextJs #669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty straight-forward drop-in replacement of vite, so there wasn't much that stood out in terms of changes. Everything I have here is nitpicks.
Agree with Danielle on the suggestions, other than that it looks good to me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, thank you! I think it's better to squash the commits when merging in this case as they all belong to the same big change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
* Replace Vite project with NextJs * Add EOF line to .eslintrc and .prettierrc * Remove next autogenerated docs * Fix layout metadata
This PR replaces the current implementation on Vite for a NextJs implementation.
It doesn't have a lot besides some boilerplate code and the auth.