Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Vite project with NextJs #669

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Replace Vite project with NextJs #669

merged 4 commits into from
Sep 14, 2023

Conversation

negreirosleo
Copy link
Contributor

This PR replaces the current implementation on Vite for a NextJs implementation.

It doesn't have a lot besides some boilerplate code and the auth.

Copy link
Collaborator

@dmtrek14 dmtrek14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty straight-forward drop-in replacement of vite, so there wasn't much that stood out in terms of changes. Everything I have here is nitpicks.

frontend/README.md Outdated Show resolved Hide resolved
frontend/src/app/layout.tsx Outdated Show resolved Hide resolved
docker/docker-compose.dev.yml Outdated Show resolved Hide resolved
@anarute
Copy link
Member

anarute commented Sep 14, 2023

Agree with Danielle on the suggestions, other than that it looks good to me :)

Copy link
Member

@anarute anarute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thank you! I think it's better to squash the commits when merging in this case as they all belong to the same big change.

Copy link
Collaborator

@dmtrek14 dmtrek14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@negreirosleo negreirosleo merged commit ce7a547 into main Sep 14, 2023
1 check passed
@negreirosleo negreirosleo deleted the add-next branch September 14, 2023 14:23
negreirosleo added a commit that referenced this pull request Mar 4, 2024
* Replace Vite project with NextJs

* Add EOF line to .eslintrc and .prettierrc

* Remove next autogenerated docs

* Fix layout metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants