Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benjamin's Hacktoberfest 2024 contribution. #76

Merged
merged 15 commits into from
Oct 30, 2024

Conversation

HarmonicReflux
Copy link
Contributor

I reflected and collected my main contributions to Hacktoberfest 2024. I was unable to meet the deadline this noon, but maybe my part can still be merged post-publication in an amend.

@HarmonicReflux HarmonicReflux self-assigned this Oct 29, 2024
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contribution was pretty long, so I've cut it a bit and split the mini-how-to as a separate entry.

docs/posts/20241021_hacktoberfest24.md Outdated Show resolved Hide resolved
docs/posts/20241021_hacktoberfest24.md Outdated Show resolved Hide resolved
docs/posts/20241021_hacktoberfest24.md Outdated Show resolved Hide resolved
created by [Matthew Yee-King](https://www.gold.ac.uk/computing/people/m-yee-king/) from Goldsmiths University London.

While it might be rewarding to get [course certificate](https://www.coursera.org/account/accomplishments/specialization/FMA5TD0N4K7E), the more relevant
parts of the repository are the implementation of a [CSV reader in C++](https://github.com/HarmonicReflux/CryptoTrade/blob/main/src/CSVReader.cpp)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice - and it needs to be mentioned as you worked on it -, but I'm quite sure there are plenty of CVS readers for C++ out there. Maybe @alexdewar can suggest a couple.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be indeed. Of course a sensitive piece of software like a CSV parser should actually come with its own tests, but I did not have time writing them in order to focus on the bigger picture. Am happy for suggestions on existing software though and/or how one would go about testing properly what I have in my project already.

docs/posts/20241021_hacktoberfest24.md Show resolved Hide resolved
docs/posts/20241021_hacktoberfest24.md Outdated Show resolved Hide resolved
docs/posts/20241021_hacktoberfest24.md Outdated Show resolved Hide resolved
HarmonicReflux and others added 6 commits October 30, 2024 12:04
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
@HarmonicReflux
Copy link
Contributor Author

HarmonicReflux commented Oct 30, 2024

There is an error in the CI pipeline regarding a broken link. It is not affiliated with the Hacktoberfest blog post, though.
Screenshot from 2024-10-30 12-16-40

Edit: It all seems to work now, upon re-triggering the failed test.

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've a minor change, but look ok, otherwise.

docs/posts/20241021_hacktoberfest24.md Outdated Show resolved Hide resolved
@HarmonicReflux HarmonicReflux merged commit 87137be into main Oct 30, 2024
4 checks passed
@HarmonicReflux HarmonicReflux deleted the Hacktoberfest_contribution_Ben branch October 30, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants