-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benjamin's Hacktoberfest 2024 contribution. #76
Conversation
for more information, see https://pre-commit.ci
…into Hacktoberfest_contribution_Ben # Conflicts: # docs/posts/20241021_hacktoberfest24.md
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contribution was pretty long, so I've cut it a bit and split the mini-how-to as a separate entry.
created by [Matthew Yee-King](https://www.gold.ac.uk/computing/people/m-yee-king/) from Goldsmiths University London. | ||
|
||
While it might be rewarding to get [course certificate](https://www.coursera.org/account/accomplishments/specialization/FMA5TD0N4K7E), the more relevant | ||
parts of the repository are the implementation of a [CSV reader in C++](https://github.com/HarmonicReflux/CryptoTrade/blob/main/src/CSVReader.cpp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice - and it needs to be mentioned as you worked on it -, but I'm quite sure there are plenty of CVS readers for C++ out there. Maybe @alexdewar can suggest a couple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be indeed. Of course a sensitive piece of software like a CSV parser should actually come with its own tests, but I did not have time writing them in order to focus on the bigger picture. Am happy for suggestions on existing software though and/or how one would go about testing properly what I have in my project already.
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've a minor change, but look ok, otherwise.
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
for more information, see https://pre-commit.ci
I reflected and collected my main contributions to Hacktoberfest 2024. I was unable to meet the deadline this noon, but maybe my part can still be merged post-publication in an amend.