-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
30 day map challenge post #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of early comments. It looks brilliant! As always with maps, it is visually super appealing.
If possible, if would be useful to share the code you use to create each map. Not the data - just point to whatever source you used - and no need to make the code full-featured repositories with best software engineering examples, but just snippets of code showing how the map were created. They can be embedded within the post, at the end, in an appendix, specially if they are long.
Tagging everyone for review, but no pressure on everyone needing to leave a review. |
@dalonsoa thanks for the speedy review, I have addressed all of your key points mentioned. I decided to give a technical overview of the tools I used for the first 3 graphs in the intro, and then give a small technical description of how that specific map was created. Is it technical enough or at all? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @Sahil590! It looks fantastic!
I have added some very minor edits.
You can add words to be ignored to .wordlist.txt |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Dan Cummins <45606273+dc2917@users.noreply.github.com>
Co-authored-by: Dan Cummins <45606273+dc2917@users.noreply.github.com>
Co-authored-by: Dan Cummins <45606273+dc2917@users.noreply.github.com>
Co-authored-by: Dan Cummins <45606273+dc2917@users.noreply.github.com>
Co-authored-by: Dan Cummins <45606273+dc2917@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! All my comments were addressed and it reads very well, so all good!
Are there any final comments for the blog post or are we ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent!
A blog post about the 30 day map challenge just included some of the maps worth talking about.
I can still add more but wanted to know if this is enough?
Any Feedback more that welcome.