Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

30 day map challenge post #84

Merged
merged 31 commits into from
Dec 13, 2024
Merged

30 day map challenge post #84

merged 31 commits into from
Dec 13, 2024

Conversation

Sahil590
Copy link
Contributor

@Sahil590 Sahil590 commented Dec 4, 2024

A blog post about the 30 day map challenge just included some of the maps worth talking about.
I can still add more but wanted to know if this is enough?
Any Feedback more that welcome.

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of early comments. It looks brilliant! As always with maps, it is visually super appealing.

If possible, if would be useful to share the code you use to create each map. Not the data - just point to whatever source you used - and no need to make the code full-featured repositories with best software engineering examples, but just snippets of code showing how the map were created. They can be embedded within the post, at the end, in an appendix, specially if they are long.

docs/posts/20241216_30day_map_challenge.md Outdated Show resolved Hide resolved
@Sahil590 Sahil590 linked an issue Dec 5, 2024 that may be closed by this pull request
@Sahil590
Copy link
Contributor Author

Sahil590 commented Dec 5, 2024

Tagging everyone for review, but no pressure on everyone needing to leave a review.

@Sahil590 Sahil590 marked this pull request as ready for review December 5, 2024 18:17
@Sahil590
Copy link
Contributor Author

Sahil590 commented Dec 6, 2024

@dalonsoa thanks for the speedy review, I have addressed all of your key points mentioned. I decided to give a technical overview of the tools I used for the first 3 graphs in the intro, and then give a small technical description of how that specific map was created. Is it technical enough or at all?
Also, some of the spell checks are flagging application names like QGIS, django, or choropleth is there a way to ignore them?

@Sahil590 Sahil590 requested a review from dalonsoa December 6, 2024 13:33
Copy link
Contributor

@SaranjeetKaur SaranjeetKaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @Sahil590! It looks fantastic!

I have added some very minor edits.

docs/posts/20241216_30day_map_challenge.md Outdated Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Outdated Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Outdated Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Outdated Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Outdated Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Outdated Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Show resolved Hide resolved
@dc2917
Copy link
Contributor

dc2917 commented Dec 9, 2024

Also, some of the spell checks are flagging application names like QGIS, django, or choropleth is there a way to ignore them?

You can add words to be ignored to .wordlist.txt

docs/posts/20241216_30day_map_challenge.md Outdated Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Outdated Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Outdated Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Outdated Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Outdated Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Show resolved Hide resolved
docs/posts/20241216_30day_map_challenge.md Show resolved Hide resolved
@Sahil590 Sahil590 changed the title 30 day map cahllenge post 30 day map challenge post Dec 10, 2024
Sahil590 and others added 7 commits December 10, 2024 09:52
Co-authored-by: Dan Cummins <45606273+dc2917@users.noreply.github.com>
Co-authored-by: Dan Cummins <45606273+dc2917@users.noreply.github.com>
Co-authored-by: Dan Cummins <45606273+dc2917@users.noreply.github.com>
Co-authored-by: Dan Cummins <45606273+dc2917@users.noreply.github.com>
Co-authored-by: Dan Cummins <45606273+dc2917@users.noreply.github.com>
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! All my comments were addressed and it reads very well, so all good!

@Sahil590 Sahil590 requested a review from dc2917 December 10, 2024 11:21
@dalonsoa
Copy link
Collaborator

Are there any final comments for the blog post or are we ready to merge?

Copy link
Contributor

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent!

@dalonsoa dalonsoa merged commit 40aa55a into main Dec 13, 2024
4 checks passed
@dalonsoa dalonsoa deleted the map-challenge branch December 13, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping data with open street maps
5 participants