-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table schema validator #125
Open
dalonsoa
wants to merge
20
commits into
main
Choose a base branch
from
table_validator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 739792d.
dalonsoa
force-pushed
the
table_validator
branch
from
December 19, 2024 08:53
b4d3fad
to
aff62f2
Compare
Drop support for python 3.9 and add support for python 3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a table schema validator for the header. This validator checks that, if there is a
schema
keyword in the header, it follows the standard defined in the Table Schema specification (mostly). This is done via pydantic models, some of them nested, and some of them discriminated based on the fieldtype_
, like it is done inPyECN
.This PRs only implements the validation of the schema if present in the header of the file. It does not enforce it or does anything with it. That is a job for future PRs, as it will need to be adapted to each reader/writer.
As the
validation.py
module was becoming pretty big, I have split it into several submodules withinvalidation
package, and the same with the tests. So the changes look more massive than they actually are. Just focus on the following two files:csvy/validators/table_schema.py
tests/validators/tests_table_schema.py
This PR incorporate the changes made in #169, dropping support for python 3.9 and adding support for 3.13. Ignore those changes or review that specific, already merged, PR.
Needless to say, there's no urgency on reviewing this.
Closes #3