-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): document shading cloud, parameters flag and more #46
base: main
Are you sure you want to change the base?
Conversation
601a28d
to
7a905fb
Compare
maven / groovy in the parameters example needs to be checked |
main.py
Outdated
<execution> | ||
<phase>package</phase> | ||
<goals> | ||
<goal>shade</goal> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor nitpick but there's some missing indentation here
Co-authored-by: Alexander Söderberg <4096670+Citymonstret@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should mention the need for mergeServiceFiles()
with shadow and the maven equivalent, without it the provided ParserContributors and BrigadierMappingContributors will not work with relocations
📚 Documentation preview 📚: https://incendocloud--46.org.readthedocs.build/en/46/