Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Successful transfer #27

Merged
merged 28 commits into from
Nov 1, 2024
Merged

feat: Successful transfer #27

merged 28 commits into from
Nov 1, 2024

Conversation

valentinperignon
Copy link
Member

@valentinperignon valentinperignon commented Oct 17, 2024 •
edited
Loading

Depends on #16

@valentinperignon valentinperignon changed the base branch from main to new-transfer October 17, 2024 07:08
@valentinperignon valentinperignon force-pushed the feat-successful-transfer branch 4 times, most recently from 97f87a0 to 9788c3a Compare October 25, 2024 09:07
@valentinperignon valentinperignon force-pushed the feat-successful-transfer branch 3 times, most recently from db9888f to e35907c Compare October 29, 2024 15:23
@valentinperignon valentinperignon marked this pull request as ready for review October 30, 2024 10:23
@Ambrdctr Ambrdctr force-pushed the new-transfer branch 2 times, most recently from fb13d05 to 1734c1b Compare October 30, 2024 12:39
Base automatically changed from new-transfer to main October 31, 2024 12:56
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

Found 27 unused code occurences

Expand 
SwissTransfer/Sources/SwissTransferApp.swift:29:17: warning: Property 'sentryService' is unused
SwissTransfer/Sources/SwissTransferApp.swift:30:17: warning: Property 'dependencyInjectionHook' is unused
SwissTransferCore/Settings/DownloadLimit+Extension.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferCore/TargetAssembly.swift:25:13: warning: Property 'appIdentifierPrefix' is unused
SwissTransferCore/Transfer+Extension.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferCoreUI/Extensions/IKButtonTheme+Extension.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferCoreUI/Modifiers/SafeAreaButtonsModifier.swift:33:9: warning: Property 'spacing' is assigned, but never used
SwissTransferCoreUI/Modifiers/SafeAreaButtonsModifier.swift:34:9: warning: Property 'background' is assigned, but never used
SwissTransferFeatures/MainView/Layouts/STSplitView.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/MainView/Layouts/STTabView.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/MainView/MainView.swift:20:1: warning: Imported module 'STReceivedView' is unused
SwissTransferFeatures/MainView/MainView.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/MainView/MainView.swift:22:1: warning: Imported module 'STSentView' is unused
SwissTransferFeatures/MainView/MainView.swift:23:1: warning: Imported module 'STSettingsView' is unused
SwissTransferFeatures/MainView/Utils/NavigableTabModifier.swift:23:8: warning: Struct 'NavigableTabModifier' is unused
SwissTransferFeatures/MainView/Utils/NavigableTabModifier.swift:45:10: warning: Function 'navigableTab(_:)' is unused
SwissTransferFeatures/NewTransferView/NewTransferFilesCellView.swift:28:24: warning: Property 'isShowingFileList' is unused
SwissTransferFeatures/NewTransferView/NewTransferSettingCell.swift:22:1: warning: Imported module 'SwissTransferCore' is unused
SwissTransferFeatures/NewTransferView/NewTransferTextFieldStyle.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/NewTransferView/NewTransferTextFieldStyle.swift:25:29: warning: Property 'isFocused' is unused
SwissTransferFeatures/NewTransferView/NewTransferTextFieldStyle.swift:29:10: warning: Function '_body(configuration:)' is unused
SwissTransferFeatures/NewTransferView/STNavigationBarNewTransferModifier.swift:19:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/NewTransferView/STNavigationBarNewTransferModifier.swift:21:1: warning: Imported module 'SwissTransferCore' is unused
SwissTransferFeatures/NewTransferView/SecurityCodeTextField.swift:112:10: warning: Function '_body(configuration:)' is unused
SwissTransferFeatures/SentView/SentView.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/TransferList/TransferCellThumbnailsView.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/TransferList/TransferList.swift:21:1: warning: Imported module 'STResources' is unused

@valentinperignon valentinperignon force-pushed the feat-successful-transfer branch 2 times, most recently from 4ba5e79 to 68556e5 Compare November 1, 2024 08:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@valentinperignon valentinperignon merged commit 177bdc5 into main Nov 1, 2024
8 checks passed
@valentinperignon valentinperignon deleted the feat-successful-transfer branch November 1, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees

@valentinperignon valentinperignon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinperignon @PhilippeWeidmann