Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upload logic #30

Merged
merged 9 commits into from
Nov 1, 2024
Merged

feat: Upload logic #30

merged 9 commits into from
Nov 1, 2024

Conversation

PhilippeWeidmann
Copy link
Member

No description provided.

@PhilippeWeidmann PhilippeWeidmann changed the base branch from main to new-transfer October 25, 2024 14:40
@PhilippeWeidmann PhilippeWeidmann deleted the feat-upload-logic branch October 30, 2024 16:14
@PhilippeWeidmann PhilippeWeidmann restored the feat-upload-logic branch October 30, 2024 16:28
Base automatically changed from new-transfer to main October 31, 2024 12:56
@PhilippeWeidmann PhilippeWeidmann marked this pull request as ready for review October 31, 2024 13:33
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Found 26 unused code occurences

Expand 
SwissTransfer/Sources/SwissTransferApp.swift:26:17: warning: Property 'sentryService' is unused
SwissTransfer/Sources/SwissTransferApp.swift:27:17: warning: Property 'dependencyInjectionHook' is unused
SwissTransferCore/Logging.swift:23:16: warning: Property 'view' is unused
SwissTransferCore/Settings/DownloadLimit+Extension.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferCore/TargetAssembly.swift:25:13: warning: Property 'appIdentifierPrefix' is unused
SwissTransferCore/Transfer+Extension.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/MainView/Layouts/STSplitView.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/MainView/Layouts/STTabView.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/MainView/MainView.swift:20:1: warning: Imported module 'STReceivedView' is unused
SwissTransferFeatures/MainView/MainView.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/MainView/MainView.swift:22:1: warning: Imported module 'STSentView' is unused
SwissTransferFeatures/MainView/MainView.swift:23:1: warning: Imported module 'STSettingsView' is unused
SwissTransferFeatures/MainView/Utils/NavigableTabModifier.swift:23:8: warning: Struct 'NavigableTabModifier' is unused
SwissTransferFeatures/MainView/Utils/NavigableTabModifier.swift:45:10: warning: Function 'navigableTab(_:)' is unused
SwissTransferFeatures/NewTransferView/NewTransferFilesCellView.swift:28:24: warning: Property 'isShowingFileList' is unused
SwissTransferFeatures/NewTransferView/NewTransferSettingCell.swift:22:1: warning: Imported module 'SwissTransferCore' is unused
SwissTransferFeatures/NewTransferView/NewTransferTextFieldStyle.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/NewTransferView/NewTransferTextFieldStyle.swift:25:29: warning: Property 'isFocused' is unused
SwissTransferFeatures/NewTransferView/NewTransferTextFieldStyle.swift:29:10: warning: Function '_body(configuration:)' is unused
SwissTransferFeatures/NewTransferView/NewTransferTypeView.swift:22:1: warning: Imported module 'SwissTransferCore' is unused
SwissTransferFeatures/NewTransferView/STNavigationBarNewTransferModifier.swift:19:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/NewTransferView/STNavigationBarNewTransferModifier.swift:21:1: warning: Imported module 'SwissTransferCore' is unused
SwissTransferFeatures/NewTransferView/SecurityCodeTextField.swift:112:10: warning: Function '_body(configuration:)' is unused
SwissTransferFeatures/SentView/SentView.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/TransferList/TransferCellThumbnailsView.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/TransferList/TransferList.swift:21:1: warning: Imported module 'STResources' is unused

@valentinperignon valentinperignon merged commit c66cd7e into main Nov 1, 2024
8 checks passed
@valentinperignon valentinperignon deleted the feat-upload-logic branch November 1, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinperignon valentinperignon valentinperignon approved these changes

Assignees

@PhilippeWeidmann PhilippeWeidmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilippeWeidmann @valentinperignon