Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Settings view #34

Merged
merged 63 commits into from
Nov 22, 2024
Merged

feat: Settings view #34

merged 63 commits into from
Nov 22, 2024

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Oct 31, 2024 •
edited
Loading

MV based setting view

Screenshot 2024-11-18 at 12 53 51

@adrien-coye adrien-coye removed the request for review from PhilippeWeidmann October 31, 2024 12:21
adrien-coye
adrien-coye commented Nov 1, 2024
View reviewed changes
Copy link
Contributor Author

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self assesment

SwissTransferFeatures/SettingsView/Cells/SettingsCell.swift Outdated Show resolved Hide resolved
SwissTransferFeatures/SettingsView/Cells/EditSettingsCell.swift Outdated Show resolved Hide resolved
SwissTransferFeatures/SettingsView/Cells/SettingsCell.swift Outdated Show resolved Hide resolved
SwissTransferFeatures/SettingsView/EditSettingView.swift Outdated Show resolved Hide resolved
SwissTransferFeatures/SettingsView/EditSettingView.swift Outdated Show resolved Hide resolved
SwissTransferFeatures/SettingsView/EditSettingView.swift Outdated Show resolved Hide resolved
SwissTransferFeatures/SettingsView/EditSettingView.swift Outdated Show resolved Hide resolved
SwissTransferFeatures/SettingsView/SettingsView.swift Outdated Show resolved Hide resolved
SwissTransferFeatures/SettingsView/SettingsView.swift Outdated Show resolved Hide resolved
SwissTransferFeatures/SettingsView/SettingsView.swift Outdated Show resolved Hide resolved
adrien-coye
adrien-coye commented Nov 11, 2024
View reviewed changes
Copy link
Contributor Author

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some self review.

SwissTransfer/Sources/SwissTransferApp.swift Outdated Show resolved Hide resolved
SwissTransferFeatures/SettingsView/EditSettings/Cells/NotificationSettingCell.swift Outdated Show resolved Hide resolved
SwissTransferFeatures/SettingsView/EditSettings/EditSettingView.swift Outdated Show resolved Hide resolved
SwissTransferFeatures/SettingsView/SettingsView.swift Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Found 19 unused code occurences

Expand 
SwissTransfer/Sources/SwissTransferApp.swift:23:1: warning: Imported module 'STResources' is unused
SwissTransfer/Sources/SwissTransferApp.swift:31:17: warning: Property 'sentryService' is unused
SwissTransfer/Sources/SwissTransferApp.swift:32:17: warning: Property 'dependencyInjectionHook' is unused
SwissTransferCore/Settings/Extensions/DownloadLimit+Extension.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferCore/Settings/SettingSelectable.swift:19:1: warning: Imported module 'STResources' is unused
SwissTransferCore/TargetAssembly.swift:25:13: warning: Property 'appIdentifierPrefix' is unused
SwissTransferCoreUI/Extensions/ColorScheme+Theme.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/MainView/Utils/NavigableTabModifier.swift:23:8: warning: Struct 'NavigableTabModifier' is unused
SwissTransferFeatures/MainView/Utils/NavigableTabModifier.swift:45:10: warning: Function 'navigableTab(_:)' is unused
SwissTransferFeatures/NewTransferView/NewTransferTextFieldStyle.swift:24:29: warning: Property 'isFocused' is unused
SwissTransferFeatures/NewTransferView/NewTransferTextFieldStyle.swift:28:10: warning: Function '_body(configuration:)' is unused
SwissTransferFeatures/NewTransferView/SecurityCodeTextField.swift:112:10: warning: Function '_body(configuration:)' is unused
SwissTransferFeatures/SettingsView/Cells/AboutSettingsCell.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/SettingsView/Cells/AboutSettingsCell.swift:22:1: warning: Imported module 'SwissTransferCore' is unused
SwissTransferFeatures/SettingsView/Cells/SettingsCell.swift:22:1: warning: Imported module 'SwissTransferCore' is unused
SwissTransferFeatures/SettingsView/Cells/SingleLabelSettingsCell.swift:22:1: warning: Imported module 'SwissTransferCore' is unused
SwissTransferFeatures/SettingsView/EditSettings/Cells/NotificationSettingCell.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/SettingsView/EditSettings/EditSettingView.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/SettingsView/SettingsView.swift:36:36: warning: Property 'settingsManager' is unused

@adrien-coye adrien-coye marked this pull request as ready for review November 11, 2024 08:48
valentinperignon
valentinperignon reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@valentinperignon valentinperignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color scheme setting seems broken, it doesn't work on my simulator

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

valentinperignon

This comment was marked as resolved.

Sign in to view

valentinperignon
valentinperignon approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@valentinperignon valentinperignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙏

@valentinperignon valentinperignon merged commit d4543ae into main Nov 22, 2024
8 checks passed
@valentinperignon valentinperignon deleted the settings_view branch November 22, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinperignon valentinperignon valentinperignon approved these changes

@Ambrdctr Ambrdctr Awaiting requested review from Ambrdctr

@PhilippeWeidmann PhilippeWeidmann Awaiting requested review from PhilippeWeidmann

Assignees

@adrien-coye adrien-coye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrien-coye @PhilippeWeidmann @valentinperignon