Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NewTransfer): Use real settings #40

Merged
merged 4 commits into from
Nov 22, 2024
Merged

feat(NewTransfer): Use real settings #40

merged 4 commits into from
Nov 22, 2024

Conversation

valentinperignon
Copy link
Member

Depends on #38

@valentinperignon valentinperignon changed the base branch from main to feat-show-success November 8, 2024 13:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

Found 20 unused code occurences

Expand 
SwissTransfer/Sources/SwissTransferApp.swift:23:1: warning: Imported module 'STResources' is unused
SwissTransfer/Sources/SwissTransferApp.swift:31:17: warning: Property 'sentryService' is unused
SwissTransfer/Sources/SwissTransferApp.swift:32:17: warning: Property 'dependencyInjectionHook' is unused
SwissTransferCore/Settings/Extensions/DownloadLimit+Extension.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferCore/Settings/SettingSelectable.swift:19:1: warning: Imported module 'STResources' is unused
SwissTransferCore/TargetAssembly.swift:25:13: warning: Property 'appIdentifierPrefix' is unused
SwissTransferCoreUI/Extensions/ColorScheme+Theme.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/MainView/Utils/NavigableTabModifier.swift:23:8: warning: Struct 'NavigableTabModifier' is unused
SwissTransferFeatures/MainView/Utils/NavigableTabModifier.swift:45:10: warning: Function 'navigableTab(_:)' is unused
SwissTransferFeatures/NewTransferView/NewTransferDetailsView.swift:24:1: warning: Imported module 'SwissTransferCore' is unused
SwissTransferFeatures/NewTransferView/NewTransferTextFieldStyle.swift:24:29: warning: Property 'isFocused' is unused
SwissTransferFeatures/NewTransferView/NewTransferTextFieldStyle.swift:28:10: warning: Function '_body(configuration:)' is unused
SwissTransferFeatures/NewTransferView/SecurityCodeTextField.swift:112:10: warning: Function '_body(configuration:)' is unused
SwissTransferFeatures/SettingsView/Cells/AboutSettingsCell.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/SettingsView/Cells/AboutSettingsCell.swift:22:1: warning: Imported module 'SwissTransferCore' is unused
SwissTransferFeatures/SettingsView/Cells/SettingsCell.swift:22:1: warning: Imported module 'SwissTransferCore' is unused
SwissTransferFeatures/SettingsView/Cells/SingleLabelSettingsCell.swift:22:1: warning: Imported module 'SwissTransferCore' is unused
SwissTransferFeatures/SettingsView/EditSettings/Cells/NotificationSettingCell.swift:20:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/SettingsView/EditSettings/EditSettingView.swift:21:1: warning: Imported module 'STResources' is unused
SwissTransferFeatures/SettingsView/SettingsView.swift:36:36: warning: Property 'settingsManager' is unused

Base automatically changed from feat-show-success to feat-upload-in-progress November 12, 2024 15:23
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

Base automatically changed from feat-upload-in-progress to main November 12, 2024 15:27
@valentinperignon valentinperignon force-pushed the feat-use-real-settings branch 2 times, most recently from 0e5dc13 to 3b9bbbd Compare November 18, 2024 12:50
@valentinperignon valentinperignon force-pushed the feat-use-real-settings branch 3 times, most recently from dc3af05 to bd79773 Compare November 22, 2024 09:49
@valentinperignon valentinperignon marked this pull request as ready for review November 22, 2024 09:52
@valentinperignon valentinperignon force-pushed the feat-use-real-settings branch 2 times, most recently from 141b278 to 26356f9 Compare November 22, 2024 10:24
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adrien-coye
adrien-coye approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the PR with the settings on simulator. All is working well to me.

@valentinperignon valentinperignon merged commit b51bc5d into main Nov 22, 2024
8 checks passed
@valentinperignon valentinperignon deleted the feat-use-real-settings branch November 22, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees

@valentinperignon valentinperignon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinperignon @adrien-coye