Fix DeclaredScopedInstance into adapted ScopedInstanceFactory #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… scope directly, and avoid leak the initial value
Nek-12
reviewed
Jan 8, 2025
|
|
||
| @PublishedApi | ||
| internal fun saveValue(id : ScopeID, value : T){ | ||
| values[id] = value |
Nek-12
reviewed
Jan 8, 2025
| } | ||
| } | ||
| return values[context.scope.id] ?: error("Scoped instance not found for ${context.scope.id} in $beanDefinition") | ||
| return values[context.scope.id] ?: throw MissingScopeValueException("Factory.get -Scoped instance not found for ${context.scope.id} in $beanDefinition") |
There was a problem hiding this comment.
This is a breaking change. Make sure you increase major version before release
There was a problem hiding this comment.
not in that case, as with such new behavior we would have ISE and can't use getOrNull. Here external behavior is the same for the user, "just" a side effect internally to handle that case
There was a problem hiding this comment.
Then this api, including exception, should be internal
There was a problem hiding this comment.
you are right, it is still an internal API. I can tag them @KoinInternalApi in 4.1 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DeclaredScopedInstance solution to provide instance declared in rework previous with ScopedInstanceFactory