-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable writing module code directly to file #1173
Open
asvarga-sedaro
wants to merge
1
commit into
Instagram:main
Choose a base branch
from
asvarga-sedaro:write-code
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ | |
# LICENSE file in the root directory of this source tree. | ||
|
||
|
||
import io | ||
from contextlib import contextmanager | ||
from dataclasses import dataclass, field | ||
from typing import Iterable, Iterator, List, Optional, Sequence, TYPE_CHECKING, Union | ||
|
@@ -70,6 +71,30 @@ | |
yield | ||
|
||
|
||
@add_slots | ||
@dataclass(frozen=False) | ||
class CodegenWriter(CodegenState): | ||
""" | ||
A CodegenState that writes to a file-like object. | ||
""" | ||
|
||
writer: io.TextIOBase = None # need a default value for dataclass | ||
|
||
def __post_init__(self) -> None: | ||
if self.writer is None: | ||
raise TypeError("writer must be provided") | ||
|
||
def add_indent_tokens(self) -> None: | ||
for token in self.indent_tokens: | ||
self.writer.write(token) | ||
|
||
def add_token(self, value: str) -> None: | ||
self.writer.write(value) | ||
|
||
def pop_trailing_newline(self) -> None: | ||
pass | ||
Comment on lines
+94
to
+95
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is incorrect, code that doesn't end in a trailing newline won't be serialized properly (for example the python module |
||
|
||
|
||
def visit_required( | ||
parent: "CSTNode", fieldname: str, node: CSTNodeT, visitor: "CSTVisitorT" | ||
) -> CSTNodeT: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the class hierarchy should be the other way around.
CodegenState
should specializeCodegenWriter
.Then we wouldn't have to have an awkward default value for
writer
.