Remove criterion-cycles-per-byte dependency and related benchmark measurement

[orf]

Summary

criterion-cycles-per-byte is not supported on non-x86_64 platforms, so cargo test cannot be run:

❯ cargo test
   Compiling libcst v0.1.0 (x)
   Compiling criterion-cycles-per-byte v0.1.2
error: criterion-cycles-per-byte currently relies on x86 or x86_64.
  --> /Users/tom/.config/cargo/registry/src/index.crates.io-6f17d22bba15001f/criterion-cycles-per-byte-0.1.2/src/lib.rs:34:1
   |
34 | compile_error!("criterion-cycles-per-byte currently relies on x86 or x86_64.");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This PR makes it conditional and allows the tests to run.

[codecov-commenter]

Codecov Report

Patch and project coverage have no change.

Comparison is base (e9bad94) 90.93% compared to head (4cb9629) 90.93%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #995   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         254      254           
  Lines       25972    25972           
=======================================
  Hits        23617    23617           
  Misses       2355     2355           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zsol]

Would you mind adding a CI step in this PR to make sure the benchmark at least compiles?

[orf]

Thanks @zsol, I've added a CI step to build the benchmark suite without running it.

[orf]

I'm afraid I don't have access to a x86_64 machine to really test this and I can't even check the compilation with criterion_cycles_per_byte added, so I'm kind of debugging via CI.

@zsol if this last build doesn't work, could we merge this without criterion_cycles_per_byte and add it back in later?

[zsol]

Yeah, I'm fine with removing cycles/byte actually; it was never accurate enough to be reliable in CI.

[orf]

Done! Thanks

[zsol]

Thank you!