Remove need for regex in TextPosition::matches (#1002) #558
clippy
200 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 200 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.72.0 (5680fa18f 2023-08-23)
- cargo 1.72.0 (103a7ff2e 2023-08-15)
- clippy 0.1.72 (5680fa18 2023-08-23)
Annotations
Check warning on line 29 in libcst/src/bin.rs
github-actions / clippy
`to_string` applied to a type that implements `Display` in `print!` args
warning: `to_string` applied to a type that implements `Display` in `print!` args
--> libcst/src/bin.rs:29:35
|
29 | print!("{}", state.to_string());
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
Check warning on line 22 in libcst/src/bin.rs
github-actions / clippy
use of `.unwrap_or_else(..)` to construct default value
warning: use of `.unwrap_or_else(..)` to construct default value
--> libcst/src/bin.rs:22:29
|
22 | let first_arg = env::args().nth(1).unwrap_or_else(|| "".to_string());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::args().nth(1).unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_else_default
= note: `#[warn(clippy::unwrap_or_else_default)]` on by default
Check warning on line 1864 in libcst/src/parser/grammar.rs
github-actions / clippy
explicit call to `.into_iter()` in function argument accepting `IntoIterator`
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> libcst/src/parser/grammar.rs:1864:25
|
1864 | a.into_iter().chain(b.into_iter()).collect()
| ^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `b`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/iter/traits/iterator.rs:522:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
Check warning on line 81 in libcst/src/parser/errors.rs
github-actions / clippy
this lifetime isn't used in the impl
warning: this lifetime isn't used in the impl
--> libcst/src/parser/errors.rs:81:10
|
81 | impl<'a> PyErrArguments for Details {
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
= note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
Check warning on line 63 in libcst/src/nodes/module.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/module.rs:63:18
|
63 | &mut (*self.eof_tok).whitespace_before.borrow_mut(),
| ^^^^^^^^^^^^^^^ help: try this: `self.eof_tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1415 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1415:18
|
1415 | &mut (*self.tok).whitespace_after.borrow_mut(),
| ^^^^^^^^^^^ help: try this: `self.tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1411 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1411:18
|
1411 | &mut (*self.tok).whitespace_before.borrow_mut(),
| ^^^^^^^^^^^ help: try this: `self.tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1312 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1312:26
|
1312 | &mut (*tok).whitespace_after.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1308 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1308:26
|
1308 | &mut (*tok).whitespace_before.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1298 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1298:26
|
1298 | &mut (*tok).whitespace_after.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1294 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1294:26
|
1294 | &mut (*tok).whitespace_before.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1284 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1284:26
|
1284 | &mut (*tok).whitespace_after.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1280 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1280:26
|
1280 | &mut (*tok).whitespace_before.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1270 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1270:26
|
1270 | &mut (*tok).whitespace_after.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1266 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1266:26
|
1266 | &mut (*tok).whitespace_before.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1256 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1256:26
|
1256 | &mut (*tok).whitespace_after.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1252 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1252:26
|
1252 | &mut (*tok).whitespace_before.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1242 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1242:26
|
1242 | &mut (*tok).whitespace_after.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1238 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1238:26
|
1238 | &mut (*tok).whitespace_before.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1228 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1228:26
|
1228 | &mut (*tok).whitespace_after.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1224 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1224:26
|
1224 | &mut (*tok).whitespace_before.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1214 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1214:26
|
1214 | &mut (*tok).whitespace_after.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1210 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1210:26
|
1210 | &mut (*tok).whitespace_before.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1200 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1200:26
|
1200 | &mut (*tok).whitespace_after.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
Check warning on line 1196 in libcst/src/nodes/op.rs
github-actions / clippy
deref which would be done by auto-deref
warning: deref which would be done by auto-deref
--> libcst/src/nodes/op.rs:1196:26
|
1196 | &mut (*tok).whitespace_before.borrow_mut(),
| ^^^^^^ help: try this: `tok`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref