Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: consistency of variable names #103

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

mancellin
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.93%. Comparing base (597cc23) to head (dad5a8d).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #103       +/-   ##
===========================================
- Coverage   79.97%   65.93%   -14.04%     
===========================================
  Files          24       24               
  Lines        3021     3018        -3     
===========================================
- Hits         2416     1990      -426     
- Misses        605     1028      +423     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maltezfaria
Copy link
Member

Thanks @mancellin . I realised we are (also) not being consistent with the four letters used for the BIEs.

I guess we should pick a convention and stick with it. @tanderson92 and @caperezar suggested S,D,K,N as in Nedelec's book. Would you mind changing those in the integral_operators.md file? ]

I can do it as well and push to this branch if you prefer.

@mancellin
Copy link
Contributor Author

Would you mind changing those in the integral_operators.md file?

Unless I've missed something, integral_operator.md already uses S,D,K,N consistently with this PR.

@maltezfaria
Copy link
Member

D' is used in some of the formulas to mean K I believe...

@maltezfaria maltezfaria merged commit e44bd2d into IntegralEquations:main Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants