Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix deprecations #2

wants to merge 4 commits into from

Conversation

apple502j
Copy link
Member

No description provided.

@jacob-g
Copy link
Member

jacob-g commented Oct 17, 2022

Since we don't use this in production (at least on EN or JA, the two Wikis that are the most extension-heavy), I am going to put this as a low priority and will review this at a later time.

Copy link
Member

@jacob-g jacob-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance, will test on my local when I get the chance.

src/PassEdit.php Outdated Show resolved Hide resolved
src/PassEdit.php Outdated Show resolved Hide resolved
Copy link
Member

@Kenny2github Kenny2github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Gerrit lingo, CR+2; pending Jacob's testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants