-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drf vite integration #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First iteration of serializers and ModelViewSets for multiple apps. Nested mutations (e.g. changing ForeignField id) still need to be implemented for PATCH and PUT REST requests. no migrations required, but python dependencies have changed
Logging out is not fully implemented yet and authorization for each API route need to be reviewed
foreignkey mutations need to be fixed
the setup of the global worker still uses CDN, but `pdfjs` is imported using node.js
automatic scrolling, dark theme, and zooming still need to be fixed
now zooming in/out does not reset parent scroll height
eventually we should keep rendering the old pdf (maybe with a small transparency) until the new pdf is ready
this allows to easily get the section name in the subs data table
it loads much faster, which makes navigation smoother
this can be fixed when the PDF worker is sourced from the npm PDF.js package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for a new frontent UI using React, Vite and related libraries. The new UI is still in experimental phase. At its current phase it adds support for new functionalities (e.g. offline mode, App-like navigation, responsive components, seamless front-side search of tabular data), but it also has yet to be implemented core features. See here for a summary of missing features:
#82