[ENHANCEMENT] Dynamic drupal trusted hosts setting. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows direct access to Drupal via the VM IP (or name) without a change to the Drupal `$settings['trusted_host_patterns']` variable.
whikloj
reviewed
Feb 7, 2020
| @@ -58,6 +58,7 @@ drupal_enable_modules: | |||
| drupal_trusted_hosts: | |||
| - ^localhost$ | |||
| - "{{ hostvars[groups['webserver'][0]].ansible_host }}" | |||
| - "^' . preg_quote($_SERVER['SERVER_NAME']) . '$" | |||
There was a problem hiding this comment.
This seems like a PHP command...does that work within the ansible framework which is (I think) Ruby?
There was a problem hiding this comment.
I think it works because settings.php is a php file? I haven't tried it yet to find out.
There was a problem hiding this comment.
Yes, running ansible with this entry added to the variables will add '^' . preg_quote($_SERVER['SERVER_NAME']) . '$' to the trusted host patterns. That means any name (or IP) you use to access the Islandora instance in the VM will automagically be trusted, so you don't need to explicitly add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
This change allows direct access to Drupal via the virtual machine IP (or hostname) without a change to the Drupal
$settings['trusted_host_patterns']variable.What's new?
Allows easier access to Islandora on the VM. However, this is not necessarily a safe change for a production installation.
How should this be tested?
Access Islandora via a non-localhost address after VM creation.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers