-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows test support #385
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joecorall
force-pushed
the
windows-tests
branch
from
April 19, 2024 11:02
b2a7b8f
to
f77420b
Compare
joecorall
force-pushed
the
windows-tests
branch
5 times, most recently
from
April 19, 2024 11:33
bf5d6af
to
7c95657
Compare
joecorall
force-pushed
the
windows-tests
branch
from
April 19, 2024 11:34
7c95657
to
58349d7
Compare
joecorall
force-pushed
the
windows-tests
branch
from
April 19, 2024 12:08
96481b6
to
f7327d7
Compare
Closing this for now since we do not have isle-buildkit windows support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets see if we can add Windows test support here.
Note on MacOS tests
Until M1 runners have docker support getting mac os tests to run on modern hardware is not possible. And adding docker support to a
macos-13
runner and getting isle-dc running takes over 30min so not feasible to test.But lets