add test for no routes, change if expression

JHWelch · Feb 19, 2024 · e4586a1 · e4586a1
1 parent 2871847
commit e4586a1
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 6 deletions.
diff --git a/__tests__/templates/MMM-CTA.njk.spec.js b/__tests__/templates/MMM-CTA.njk.spec.js
@@ -161,3 +161,20 @@ describe('multiple stops', () => {
     expect(template).toContain('Train Stop');
   });
 });
+
+describe('no stops', () => {
+  beforeEach(() => {
+    data = {
+      stops: [{
+        type: 'bus',
+        name: 'Bus Stop',
+        arrivals: [],
+      }],
+    };
+    template = nunjucks.render('MMM-CTA.njk', data);
+  });
+
+  it('shows no arrivals', () => {
+    expect(template).toContain('No scheduled arrivals.');
+  });
+});
diff --git a/templates/MMM-CTA.njk b/templates/MMM-CTA.njk
@@ -23,10 +23,10 @@
           </tr>
 
           <tr class="small">
-            {% if routeIcons %}
-              <th class="align-left"></th>
-            {% endif %}
-            {% if stop.arrivals[0].arrival %}
+            {% if stop.arrivals.length %}
+              {% if routeIcons %}
+                <th class="align-left"></th>
+              {% endif %}
               <th class="align-left">
                 {{ "DIRECTION" | translate }}
               </th>
@@ -38,7 +38,7 @@
           </tr>
         </thead>
         <tbody>
-	        {% if stop.arrivals[0].arrival %}
+	        {% if stop.arrivals.length %}
             {% for arrival in stop.arrivals %}
               <tr class="small">
                 {% if routeIcons %}
@@ -61,7 +61,7 @@
               </tr>
             {% endfor %}
 	        {% else %}
-	          <td class="small">No planned arrivals.</td>
+	          <td class="small">No scheduled arrivals.</td>
 	        {% endif %}
         </tbody>
       </table>